Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building Python 3.13 wheels, and bump MacOS version #249

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

marsfan
Copy link
Contributor

@marsfan marsfan commented Nov 14, 2024

Added new tasks to the build matrix to support building Python 3.13 wheels.

Currently, building the wheel is successful in Github Actions, but running the tests fails (See run on my branch here). I've identified that the source of the failures is not due to any issues actually failing with the unit tests, but actually is due to the fact that scikit-image does not yet have release builds that support Python 3.13 (See scikit-image/scikit-image#7596). When I install the pre-release builds for scikit-image on my computer, and run unit tests manually, the unit tests all pass.

Until scikit-image has an official release of 0.25, which will add Python 3.13 support, I'm going to leave this pull request in a draft state. Once there is an official release, I will change that.

Note: I have made no effort to add free-threading support to this module. There's a guide here that may be useful.

@marsfan marsfan changed the title Add support for building Python 3.13 wheels Add support for building Python 3.13 wheels, and bump MacOS version Dec 14, 2024
@marsfan marsfan marked this pull request as ready for review December 14, 2024 02:39
@marsfan
Copy link
Contributor Author

marsfan commented Dec 14, 2024

Scikit-Image support for 3.13 is finally out, so the full results of the CI run can be performed. I also had to bump the MacOS 12 configurations in the matrix to MacOS 13, as GitHub removed MacOS-12 runners.

Results from running the CI here: https://github.com/marsfan/rawpy/actions/runs/12325195566

Copy link
Owner

@letmaik letmaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@letmaik letmaik merged commit 87e98c4 into letmaik:main Dec 14, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants