Adds new validation to citation field

Issue: documentacao-e-tarefas/scielo#724 Signed-off-by: Jhon <[email protected]>
lepidus · Dec 4, 2024 · 760208e · 760208e
1 parent 26e82f6
commit 760208e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/api/v1/translationsFields/TranslationsFieldsHandler.php b/api/v1/translationsFields/TranslationsFieldsHandler.php
@@ -66,13 +66,15 @@ public function saveTranslationFields($slimRequest, $response, $args)
         $originalDocumentDoi = $requestParams['originalDocumentDoi'];
         $originalDocumentCitation = null;
 
-        if ($originalDocumentHasDoi && $this->validateOriginalDoi($originalDocumentDoi)) {
-            $doiClient = new DoiClient();
-            $originalDocumentCitation = $doiClient->getApaCitation($originalDocumentDoi);
-        } elseif ($placedOn == 'workflow') {
-            return $response->withStatus(400)->withJson([
-                'originalDocumentDoi' => [__('plugins.generic.scieloTranslationsFields.originalDocumentDoi.invalidDoi')]
-            ]);
+        if ($originalDocumentHasDoi) {
+            if ($this->validateOriginalDoi($originalDocumentDoi)) {
+                $doiClient = new DoiClient();
+                $originalDocumentCitation = $doiClient->getApaCitation($originalDocumentDoi);
+            } elseif ($placedOn == 'workflow') {
+                return $response->withStatus(400)->withJson([
+                    'originalDocumentDoi' => [__('plugins.generic.scieloTranslationsFields.originalDocumentDoi.invalidDoi')]
+                ]);
+            }
         }
 
         Repo::publication()->edit($publication, [

diff --git a/classes/components/forms/TranslationDataForm.php b/classes/components/forms/TranslationDataForm.php
@@ -53,6 +53,7 @@ public function __construct($action, $submission, $placedOn)
             $this->addField(new FieldHTML('originalDocumentDoi', [
                 'label' => __('plugins.generic.scieloTranslationsFields.originalDocumentCitation'),
                 'description' => "<p style=\"text-align: justify\">{$originalDocumentCitation}</p>",
+                'showWhen' => ['originalDocumentHasDoi', 1]
             ]));
         }
     }