-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/integration-tests #115
Conversation
@aguilaair for tomorrow: do you know why this happens on github actions:
I tried to copy the preparation steps before running the |
After meeting with @Ahmadre we have concluded the issue was related to the presence of the |
I'll look into why this is still failing ASAP. |
…e/sidekick into feature/integration-tests
I had now the same error when I setup my fresh windows. I think it is because FVM is not installed as a dependency. I added a step to install it, but maybe my PATH is not correct. |
Thanks @aguilaair for your fix to get the tests running. I will cover all other components and write the integration tests for them and then it should be merged :) |
@leoafarias I recognized that the Mouse Cursor was wrong here: That was because of the null value in IconButton, so I fixed that also here: MouseRegion(
cursor: SystemMouseCursors.click,
child: Padding(
/// This is the same padding as `IconButton`
padding: const EdgeInsets.all(8.0),
child: Icon(
expand ? MdiIcons.chevronDown : MdiIcons.chevronUp,
),
),
), |
@Ahmadre thanks for fixing this. Let me know once this is ready for review. |
I am trying to write the most important test for installing and updating a release in the ReleasesScreen. But I'm stuck here: I'm not really secure with the actual codebase and I don't know which async process I should use here. The reason is: I need to wait for a success or failure notification to test this part properly. For that I would like to use Do you guys have any idea? Or have maybe some time to take a look at it in Zoom? |
@rebarah After you install the release, the fvm_queue.provider.dart will keep track of any active items. I believe the best way to is to wait for the active item to switch and to recheck the status of the release. Let me know if that helps, if not we can coordinate a zoom call. |
Sounds great :)! Thanks I'll do that 💪🏼 |
@aguilaair talked with @Ahmadre and we will be taking over finalizing this |
Moving this to #165 so we can make edits |
Motivation
For the Release 1.0 of Sidekick, all features have to be tested well. To do so, Integration Tests helps us here to make sure our app is working on different devices and environments.
Besides this PR, I would also recommend Unit-Tests so developers are getting immediately a feedback while they're coding. E2E Tests are taking a bit longer. You can test them locally, but the main purpose for this PR is that these Tests will run in a CI-Environment so that Github Actions is doing that job for us.
This PR is not using any packages, it relies on the latest integration_test package from Flutter Framework which got efficient updates where we can combine everything with external tools (like Test Lab and so on).
Related Issues
Closes: #97