Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assignVersionWeight do not handle custom version #694

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix assignVersionWeight do not handle custom version #694

merged 1 commit into from
Mar 27, 2024

Conversation

quyenvsp
Copy link
Contributor

assignVersionWeight function should remove custom_ before parse version else fvm dart will not working because

bool get hasOldBinPath {
  return compareSemver(assignVersionWeight(version), '1.17.5') <= 0;
}

Fixes #654 (comment)

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024

@quyenvsp is attempting to deploy a commit to the FlutterTools Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fvm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 4:05pm

leoafarias
leoafarias approved these changes Mar 27, 2024
View reviewed changes
lib/src/utils/helpers.dart Show resolved Hide resolved
@leoafarias leoafarias merged commit 6b70042 into leoafarias:main Mar 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias leoafarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quyenvsp @leoafarias