-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: dismiss event from notification #781
Open
gsbernstein
wants to merge
11
commits into
leits:master
Choose a base branch
from
gsbernstein:dismiss-from-notification
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
feature
New feature or request
labels
Nov 20, 2024
gsbernstein
commented
Nov 20, 2024
> (released) | ||
|
||
* Added action to dismiss the event from the notification | ||
|
||
## Version 4.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I added to the changelogs as requested but they both seem out of date. Are they deprecated? Should I updated the PR template?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
I often found myself wanting to dismiss events from the notification, rather than dismissing the notification and then opening the menu and then dismissing the event.
Also:
Note:
notification_next_meeting_dismissed_title
notification triggered by dismissing. I find it more annoying than useful. This change might make that even more apparent. I'd be happy to remove that as well or add it as an option to settings.Checklist
Steps to Test or Reproduce