Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: dismiss event from notification #781

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

gsbernstein
Copy link
Contributor

@gsbernstein gsbernstein commented Nov 20, 2024

Status

READY

Description

I often found myself wanting to dismiss events from the notification, rather than dismissing the notification and then opening the menu and then dismissing the event.

Also:

  • consolidated handling of events in the response handler
  • fixed a couple minor typos

Note:

  • for personal use, I have disabled the notification_next_meeting_dismissed_title notification triggered by dismissing. I find it more annoying than useful. This change might make that even more apparent. I'd be happy to remove that as well or add it as an option to settings.

Checklist

Steps to Test or Reproduce

  • create an event in the near future
  • await notification
  • open the notification actions
  • select "dismiss"

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. feature New feature or request labels Nov 20, 2024
> (released)

* Added action to dismiss the event from the notification

## Version 4.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I added to the changelogs as requested but they both seem out of date. Are they deprecated? Should I updated the PR template?

MeetingBar/AppDelegate.swift Fixed Show fixed Hide fixed
MeetingBar/AppDelegate.swift Fixed Show fixed Hide fixed
MeetingBar/Notifications.swift Fixed Show fixed Hide fixed
MeetingBar/StatusBarItemController.swift Fixed Show fixed Hide fixed
MeetingBar/StatusBarItemController.swift Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant