Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Add support for SaunaFS commit hash #3

Closed
wants to merge 1 commit into from

Conversation

ralcolea
Copy link

This commit allows the SaunaFS commit hash to be passed as a build argument. This ensures CI tests reliably use the exact version of the code being tested.

This commit allows the SaunaFS commit hash to be passed as a build
argument. This ensures CI tests reliably use the exact version of the
code being tested.

Signed-off-by: Crash <[email protected]>
@ralcolea ralcolea requested a review from uristdwarf January 23, 2025 16:57
@ralcolea ralcolea self-assigned this Jan 23, 2025
@uristdwarf
Copy link
Contributor

I don't think this is needed anymore, as the issue it was trying to solve in a test was solved another way (by using SOURCE_DIR). Furthermore, in the future the Dockerfile will be located in the leil-io/saunafs repository instead.

@uristdwarf uristdwarf closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants