chore(chunkserver): Apply pending readability refactor #284
+38
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgsilva3087
requested review from
uristdwarf,
ralcolea,
antuan96314 and
rolysr
lgsilva3087
force-pushed
the
chore-apply-pending-pr-suggestions
branch
from
8e70b17 to
b61909a
Compare
lgsilva3087
force-pushed
the
chore-apply-pending-pr-suggestions
branch
from
b61909a to
0cd4dfa
Compare
This commit applies old PR suggestions to improve the readability of the ChunkserverEntry struct and the NetworkWorkerThread class: - Replace old magic constants by using named constants. - Give more context about selected constants. Signed-off-by: guillex <[email protected]>
lgsilva3087
force-pushed
the
chore-apply-pending-pr-suggestions
branch
from
0cd4dfa to
3206f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit applies old PR suggestions to improve the readability of the ChunkserverEntry struct and the NetworkWorkerThread class: