Improvements to uRaft #136
Draft
+531
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uristdwarf
force-pushed
the
uraft-general
branch
from
67d75ea to
752b54c
Compare
antuan96314
reviewed
Jul 16, 2024
ictus4u
previously approved these changes
Jul 18, 2024
ictus4u
reviewed
Jul 18, 2024
|
@uristdwarf The github rebase button seems to do the opposite to what we want (it brings the changes in the opposite direction, leaving a weird shape in the graph), please, rebase from your computer if it is your will. |
uristdwarf
force-pushed
the
uraft-general
branch
2 times, most recently
from
ec0c613 to
ebbed7c
Compare
I actually want it to be fast-forwarded, so that all commits are preserved in dev. But maybe a merge will suffice. |
uristdwarf
force-pushed
the
uraft-general
branch
from
ebbed7c to
7cf75a0
Compare
ictus4u
reviewed
Aug 8, 2024
uristdwarf
force-pushed
the
uraft-general
branch
from
7cf75a0 to
668dc5e
Compare
uristdwarf
force-pushed
the
uraft-general
branch
2 times, most recently
from
d8b9665 to
d7e869b
Compare
uristdwarf
force-pushed
the
uraft-general
branch
2 times, most recently
from
f68ed79 to
0d5e672
Compare
uristdwarf
force-pushed
the
uraft-general
branch
from
0d5e672 to
458dec6
Compare
When the binary for tests was moved to a different path it could not find the tests bash script. This commit adds an environment variable to allow the path change in run time. Co-authored-by: Antuan <[email protected]> Co-authored-by: Crash <[email protected]>
This for example allows using environment variables to set logging levels.
* Fix clang-tidy linting warnings/hints * Use slogger instead of only syslog * Allow setting env variable to enable specific levels of logging
The helper script couldn't correctly read the files unless there were no spaces between the key values.
* Add more thorough logging (including logging to stderr) * Allow passing some env variables through parent * Allow setting log level by setting the SAUNAFS_LOG_LEVEL variable
Co-authored-by: Walter Gomez <[email protected]>
uristdwarf
force-pushed
the
uraft-general
branch
from
458dec6 to
cc5a041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch series. DO NOT MERGE OR SQUASH THIS, DO REBASE INSTEAD
Generally refactoring and fixing clang-tidy warnings/hints. This is in preparation for some fundamental changes to how uRaft works. It also improves logging (by logging to both syslog and
stderr) and fixes a bug with key-values not being correctly parsed from the uRaft helper script.