Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix PMT DSP #58

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Bug Fix PMT DSP #58

merged 2 commits into from
Feb 19, 2025

Conversation

theHenks
Copy link
Collaborator

@theHenks theHenks commented Feb 19, 2025

This PR contains:

  • Updated dsp_pmts function to adapt to new metadata structure
  • Used standard SavitzkyGolayFilter instead of WeightedSavitzkyGolay to improve speed
  • Bug Fix in IntersectMaximum in case the first sample is already a trigger

CC @MayaMenzel

@theHenks theHenks self-assigned this Feb 19, 2025
@theHenks theHenks added the bug Something isn't working label Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 30.55%. Comparing base (6d1655b) to head (7b0e97e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/dsp_pmts.jl 0.00% 18 Missing ⚠️
src/intersect_maximum.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   30.65%   30.55%   -0.10%     
==========================================
  Files          24       24              
  Lines        1233     1237       +4     
==========================================
  Hits          378      378              
- Misses        855      859       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theHenks theHenks merged commit 7459de0 into main Feb 19, 2025
8 of 10 checks passed
@theHenks theHenks deleted the patch_dsp-pmts branch February 19, 2025 01:47
@fhagemann fhagemann mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant