Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waveform maxima after filtering to DSP output as energy extractors #55

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

theHenks
Copy link
Collaborator

The PR adds the maxima in addition to the fixed-time pick-off for the current used three different filter types trap, cusp and zac. In addition, the time point of the maximum is saved too.

@theHenks theHenks requested a review from fhagemann February 13, 2025 16:00
@theHenks theHenks self-assigned this Feb 13, 2025
@theHenks theHenks added the enhancement New feature or request label Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 30.58%. Comparing base (8d13b5e) to head (d0a3df8).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/dsp_icpc.jl 0.00% 17 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   30.58%   30.58%           
=======================================
  Files          24       24           
  Lines        1236     1236           
=======================================
  Hits          378      378           
  Misses        858      858           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theHenks theHenks merged commit 9de9777 into main Feb 16, 2025
9 of 10 checks passed
@theHenks theHenks deleted the dsp-icpc-energy-max branch February 16, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants