minor assorted changes

cobc:
* field.c (cleanup_field_value): cleanup for national space
* scanner.l (scan_x): build "implied for empty" N / NX literal with correct size
* scanner.l, tree.c (cb_concat_literals): output explanations of literal errors as "note" instead of "error"
* typeck.c (cb_build_move_field): generate optimized code for reference-modification with same ref-mod length
* codegen.c (output_search_all): dropped unnecessary check
* codegen.c (output_search): add missing ODO runtime check
* codegen.c (output_search_whens): generate access to ODO value only once, instead of on every internal SEARCH VARYING
* codegen.c (output_param): reduce scope of variables
* tree.c: minor refactoring
* cobc.c: minor speedup in freeing memory
* reserved.c (get_user_specified_reserved_word): minor refactoring

config/rm-strict.conf: enable line-col-zero-default per RM-COBOL Language Reference for POSITION with implied zero

configure.ac: fixed typo, now searching for pdcurses.h again

THANKS: reformatted and extended

THANKS

@@ -1,78 +1,89 @@
-Previous and current project maintainers:
+Past and present maintainers:
 
 Keisuke Nishida <[email protected]>
 Roger While (1950-2015)
 Simon Sobisch <[email protected]>
 
 
-Additional main developers with huge code and design contributions:
+Other core developers with major code and design contributions
 
-Ron Norman <[email protected]> including for, but not limited to:
-  - implementation and ongoing work on C-/D-/VBISAM handler
-  - development of Report Writer
-  - external EXTFH along with ADDRESS OF FH--FCD and FH--KEYDEF
-  - improved compatibility to Micro Focus COBOL
-  - runtime configuration
-  - C-API for inspect/update COBOL data fields
-  - dump on abort
+Ron Norman <[email protected]> including but not limited to
+  - Implementation and ongoing work on the C-/D-/VBISAM handler
+  - Report Writer development
+  - Standard EXTFH together with ADDRESS OF FH--FCD and FH--KEYDEF
+  - Improved compatibility with Micro Focus COBOL
+  - Runtime configuration
+  - C-API to inspect/update COBOL data fields
+  - Dump on abort
+  - Performance improvements
 
-Edward Hart <[email protected]> including for, but not limited to:
-  - fine-grained configuration of runtime checks
-  - compiler configuration, especially reserved word handling
+Edward Hart <[email protected]> including but not limited to
+  - fine-grained configuration of run-time checks
+  - Compiler configuration, in particular reserved word handling
   - datetime intrinsic functions
-  - XML GNERATE and JSON GENERATE
-  - initial support for internal repository (function and program prototypes)
-  - syntax support for standard COBOL and existing implementor extensions
-  - bug fixing and improving the testsuite
+  - XML GENERATE and JSON GENERATE
+  - Initial support for internal repository (function and program prototypes)
+  - Syntax support for standard COBOL and existing implementor extensions
+  - Bug fixes and test suite enhancements
 
 
-Further more explicit thanks to:
+We are grateful for the work of the Translation Project, its translation teams
+and their individual contributors, who provide translations of user messages
+for non-English speakers.
 
-Alain Lucari <[email protected]>
-Brian Tiffin <[email protected]>
-David Korn <[email protected]>
-Dave Pitts <[email protected]>
-Joe Robbins (-2017)
-Keiichi Takahashi <[email protected]>
-Peg <[email protected]>
-Richard Smith <[email protected]>
-Thomas Biehler <[email protected]>
-William M. Klein <[email protected]>
-Yoshiki Kusumoto <[email protected]>
+Similar thanks go to all the packagers who allow users to install GnuCOBOL from
+their distributions' package management systems.
 
-We are thankful for the work of the Translation Project, their translation
-teams and their one-time contributors, providing the translation of user
-messages for non-English speakers.
+Also to the many people that have helped with testing this software.
+We hope that everyone will continue to provide feedback. This is invaluable
+to the ongoing development process.
 
-Also to the many people that have helped out in testing this software.
-We hope that everybody will continue to provide feedback. This is invaluable
-to the continuing development process.
-
-A special mention here of people who have provided exceptional support in terms
-of time and resources on hardware that was not available to the developers:
-Oleg Philon - For his work on the PowerPC
-David Wilson - For his work on the MAC (Darwin)
+A special mention here goes to people who have given exceptional support in
+terms of time and resources on hardware that was not available to the
+developers:
+Oleg Philon     - For his work on the PowerPC
+David Wilson    - For his work on the MAC (Darwin)
 Sergey Kashyrin - For his work on:
   - SUN Solaris
   - IBM AIX
   - HP-UX
 
 And continuing this amazing support:
+Arnold Trembley <[email protected]> - Win32 packaging and user support
+Chuck Haatvedt <[email protected]> - Work on optimized BCD handling
 Ludwin Janvier <[email protected]> - patches for build/packaging issues
 Hans-Martin Rasch - Work on compiler syntax
 Michel Gouget - Work on syntax - IS
 Bill Klein - The mainstay for COBOL questions
 Frank Swarbrick - Work on compiler syntax
-Warren Gay - For testing systems that we didn't known that we even support!
-   (eg. old DEC Alpha systems)
+Warren Gay - For testing systems we didn't even know we supported!
+   (e.g. old DEC Alpha systems)
 Fabrizio Calabretta - Work on the internal EXTFH interface
 
+Gary L. Cutler <[email protected]> and Vincent B. Coen <[email protected]> for
+writing and maintaining the GnuCOBOL Programmer's Guide.
+
 OCamlPro SAS for assigning David Declerck, Nicolas Berthier and
 Fabrice Le Fessant to work for adding GCOS (Bull) support and
 contributing the result.
 
-Denis Hugonnard-Roche for ongoing additions to the internal testsuite to
-improve code-coverage.
+Denis Hugonnard-Roche for continuous additions to the internal test suite to
+improve code coverage.
+
+
+Further explicit thanks to
+
+Alain Lucari <[email protected]>
+Brian Tiffin <[email protected]>
+David Korn <[email protected]>
+Dave Pitts <[email protected]>
+Joe Robbins (-2017)
+Keiichi Takahashi <[email protected]>
+Peg <[email protected]>
+Richard Smith <[email protected]>
+Thomas Biehler <[email protected]>
+William M. Klein <[email protected]>
+Yoshiki Kusumoto <[email protected]>
 
 
 -------------------------------------------------------------------------------
@@ -88,7 +99,7 @@ OpenCOBOL was inspired by the TinyCOBOL project.
 Thanks to the TinyCOBOL authors and maintainers.
 
 
-Additional from TinCOBOL:
+Additional from TinyCOBOL:
 
 Rildo Pragana (1958-2020)
 

cobc/ChangeLog

@@ -7,6 +7,30 @@
 	  national literals
 	* typeck.c (validate_move): don't permit alphanumeric literals in VALUE
 	  clause for numeric items
+	* field.c (cleanup_field_value): cleanup for national space
+	* scanner.l (scan_x): build "implied for empty" N / NX literal with
+	  correct size
+	* scanner.l, tree.c (cb_concat_literals): output explanations of literal
+	  errors as "note" instead of "error"
+	* tree.c: minor refactoring
+
+2023-03-28  Simon Sobisch <[email protected]>
+
+	* codegen.c (output_search_all): dropped unnecessary check
+	* codegen.c (output_search): add missing ODO runtime check
+	* codegen.c (output_search_whens): generate access to ODO value only once,
+	  instead of on every internal SEARCH VARYING
+	* codegen.c (output_param): reduce scope of variables
+
+2023-03-24  Simon Sobisch <[email protected]>
+
+	* cobc.c: minor speedup in freeing memory
+	* reserved.c (get_user_specified_reserved_word): minor refactoring
+
+2023-03-23  Simon Sobisch <[email protected]>
+
+	* typeck.c (cb_build_move_field): generate optimized code for
+	  reference-modification with same ref-mod length
 
 2023-03-08  Emilien Lemaire <[email protected]>
 

cobc/cobc.c

@@ -574,7 +574,7 @@ static const struct option long_options[] = {
 	{"std",			CB_RQ_ARG, NULL, '$'},
 	{"conf",		CB_RQ_ARG, NULL, '&'},
 	{"debug",		CB_NO_ARG, NULL, 'd'},
-	{"ext",			CB_RQ_ARG, NULL, 'e'},
+	{"ext",			CB_RQ_ARG, NULL, 'e'},	/* note: kept *undocumented* until GC4, will be changed to '.' */
 	{"free",		CB_NO_ARG, NULL, 'F'},	/* note: not assigned directly as this is only valid for */
 	{"fixed",		CB_NO_ARG, NULL, 'f'},	/*       `int` and sizeof(enum) isn't always sizeof (int) */
 	{"static",		CB_NO_ARG, &cb_flag_static_call, 1},
@@ -1087,9 +1087,9 @@ cobc_main_stradd_dup (const char *str1, const char *str2)
 void *
 cobc_main_realloc (void *prevptr, const size_t size)
 {
+	register struct cobc_mem_struct	*curr;
+	register struct cobc_mem_struct	*prev;
 	struct cobc_mem_struct	*m;
-	struct cobc_mem_struct	*curr;
-	struct cobc_mem_struct	*prev;
 
 	m = calloc ((size_t)1, COBC_MEM_SIZE + size);
 	/* LCOV_EXCL_START */
@@ -1131,8 +1131,8 @@ cobc_main_realloc (void *prevptr, const size_t size)
 void
 cobc_main_free (void *prevptr)
 {
-	struct cobc_mem_struct	*curr;
-	struct cobc_mem_struct	*prev;
+	register struct cobc_mem_struct	*curr;
+	register struct cobc_mem_struct	*prev;
 
 	prev = NULL;
 	for (curr = cobc_mainmem_base; curr; curr = curr->next) {
@@ -1203,9 +1203,9 @@ cobc_parse_strdup (const char *dupstr)
 void *
 cobc_parse_realloc (void *prevptr, const size_t size)
 {
+	register struct cobc_mem_struct	*curr;
+	register struct cobc_mem_struct	*prev;
 	struct cobc_mem_struct	*m;
-	struct cobc_mem_struct	*curr;
-	struct cobc_mem_struct	*prev;
 
 	m = calloc ((size_t)1, COBC_MEM_SIZE + size);
 	/* LCOV_EXCL_START */
@@ -1247,8 +1247,8 @@ cobc_parse_realloc (void *prevptr, const size_t size)
 void
 cobc_parse_free (void *prevptr)
 {
-	struct cobc_mem_struct	*curr;
-	struct cobc_mem_struct	*prev;
+	register struct cobc_mem_struct	*curr;
+	register struct cobc_mem_struct	*prev;
 
 	prev = NULL;
 	for (curr = cobc_parsemem_base; curr; curr = curr->next) {
@@ -3616,7 +3616,8 @@ process_command_line (const int argc, char **argv)
 #endif
 			break;
 
-		case 'e':
+		case 'e':	/* until GC 4 we keep (undocumented) 'e',
+			     	   but that's reserved for possible --error-log */
 			/* -ext <xx> : Add an extension suffix */
 			if (strlen (cob_optarg) > 15U) {
 				cobc_err_exit (COBC_INV_PAR, "--ext");