fix single stack-use-after-scope found by AddressSanitizer

libcob/common.c (cob_cmp): fix stack-use-after-scope for comparisons of unsigned numeric with non-numeric field
lefessan · Jan 4, 2023 · 617c03b · 617c03b
1 parent ca129c7
commit 617c03b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/libcob/ChangeLog b/libcob/ChangeLog
@@ -1,4 +1,9 @@
 
+2023-01-04  Simon Sobisch <[email protected]>
+
+	* common.c (cob_cmp): fix stack-use-after-scope for comparisons of unsigned
+	  numeric with non-numeric field
+
 2023-01-03  Simon Sobisch <[email protected]>
 
 	* common.c (cob_accept_date, cob_accept_date_yyyymmdd, cob_accept_day,

diff --git a/libcob/common.c b/libcob/common.c
@@ -3868,7 +3868,11 @@ cob_cmp (cob_field *f1, cob_field *f2)
 				return cob_cmp_alnum (f1, f2);
 			}
 		}
+		/* done here to have the data for non-signed numeric vs. non-numeric in scope */
+		return cob_cmp_alnum (f1, f2);
 	}
+
+	/* both data not numeric: compare as string */
 	return cob_cmp_alnum (f1, f2);
 }