work on handling binary operations in the compiler

cobc:
* tree.h (cb_binary_op, cb_binary_op_flag, cb_binary_op_op): changed struct cb_binary_op to use new enums for the actual operation and for "special flags" instead of storing those in integers with special value
* tree.h (BOP_OPERANDS_SWAPPED), typeck.c (cb_build_cond, swap_condition_operands), codegen.c (output_cond): store flag when swap operation is done and swap the result for return values as used in `SEARCH ALL` later
* codegen.c (output_long_integer): reduce scope of variables as done in (output_integer)

cobc/ChangeLog

@@ -1,4 +1,14 @@
 
+2022-12-16  Simon Sobisch <[email protected]>
+
+	* tree.h (cb_binary_op, cb_binary_op_flag, cb_binary_op_op): changed struct
+	  cb_binary_op to use new enums for the operation and for "special flags"
+	* tree.h (BOP_OPERANDS_SWAPPED), codegen.c (output_cond), typeck.c
+	  (cb_build_cond, swap_condition_operands): store flag when swap operation
+	  is done and swap the result for return values as used in SEARCH ALL later
+	* codegen.c (output_long_integer): reduce scope of variables as done
+	  in (output_integer)
+
 2022-12-15  Simon Sobisch <[email protected]>
 
 	* codegen.c (output_initialize_to_value): fix bad generation for VALUE size
@@ -18,7 +28,6 @@
 	* typeck.c (cb_build_cond_fields): optimize comparison between field and
 	  SPACES up to COB_SPACES_ALPHABETIC_BYTE_LENGTH
 
-
 2022-12-14  Simon Sobisch <[email protected]>
 
 	* typeck.c (validate_move): fix bug #643 add check for SET literal TO val

cobc/codegen.c

@@ -2885,7 +2885,7 @@ output_integer (cb_tree x)
 		break;
 	case CB_TAG_BINARY_OP: {
 		const struct cb_binary_op *p = CB_BINARY_OP (x);
-		if (p->flag) {
+		if (p->flag == BOP_RESOLVE_AS_INTEGER) {
 			if (!cb_fits_int (p->x) || !cb_fits_int (p->y)) {
 				output ("cob_get_int (");
 				output_param (x, -1);
@@ -3177,10 +3177,6 @@ output_integer (cb_tree x)
 static void
 output_long_integer (cb_tree x)
 {
-	struct cb_binary_op	*p;
-	struct cb_cast		*cp;
-	struct cb_field		*f;
-
 	switch (CB_TREE_TAG (x)) {
 	case CB_TAG_CONST:
 		if (x == cb_zero) {
@@ -3206,9 +3202,9 @@ output_long_integer (cb_tree x)
 	case CB_TAG_LITERAL:
 		output (CB_FMT_LLD_F, cb_get_long_long (x));
 		break;
-	case CB_TAG_BINARY_OP:
-		p = CB_BINARY_OP (x);
-		if (p->flag) {
+	case CB_TAG_BINARY_OP: {
+		const struct cb_binary_op *p = CB_BINARY_OP (x);
+		if (p->flag == BOP_RESOLVE_AS_INTEGER) {
 			if (!cb_fits_long_long (p->x) ||
 			    !cb_fits_long_long (p->y)) {
 				output ("cob_get_llint (");
@@ -3232,8 +3228,9 @@ output_long_integer (cb_tree x)
 			output (")");
 		}
 		break;
-	case CB_TAG_CAST:
-		cp = CB_CAST (x);
+	}
+	case CB_TAG_CAST: {
+		const struct cb_cast *cp = CB_CAST (x);
 		switch (cp->cast_type) {
 		case CB_CAST_ADDRESS:
 			output ("(");
@@ -3258,8 +3255,9 @@ output_long_integer (cb_tree x)
 		/* LCOV_EXCL_STOP */
 		}
 		break;
-	case CB_TAG_REFERENCE:
-		f = cb_code_field (x);
+	}
+	case CB_TAG_REFERENCE: {
+		struct cb_field *f = cb_code_field (x);
 		switch (f->usage) {
 		case CB_USAGE_INDEX:
 			if (f->index_type != CB_NORMAL_INDEX) {
@@ -3410,6 +3408,7 @@ output_long_integer (cb_tree x)
 
 		output_func_1 ("cob_get_llint", x);
 		break;
+	}
 	case CB_TAG_INTRINSIC:
 		output ("cob_get_llint (");
 		output_param (x, -1);
@@ -4326,12 +4325,13 @@ output_func_1 (const char *name, cb_tree x)
 
 /* Condition */
 
+/* output condition 'x' with optional storage in
+   C field "ret" depending on 'save_flag' */
 static void
 output_cond (cb_tree x, const int save_flag)
 {
-	struct cb_binary_op	*p;
-
 	in_cond = 1;
+
 	switch (CB_TREE_TAG (x)) {
 	case CB_TAG_CONST:
 		if (x == cb_true) {
@@ -4345,8 +4345,8 @@ output_cond (cb_tree x, const int save_flag)
 		}
 		/* LCOV_EXCL_STOP */
 		break;
-	case CB_TAG_BINARY_OP:
-		p = CB_BINARY_OP (x);
+	case CB_TAG_BINARY_OP: {
+		const struct cb_binary_op	*p = CB_BINARY_OP (x);
 		switch (p->op) {
 		case '!':
 			output ("!");
@@ -4372,7 +4372,12 @@ output_cond (cb_tree x, const int save_flag)
 		case ']':
 		case '~':
 			output ("((int)");
-			output_cond (p->x, save_flag);
+			if (save_flag
+				&& p->flag == BOP_OPERANDS_SWAPPED) {
+				output_cond (p->x, 2);
+			} else {
+				output_cond (p->x, save_flag);
+			}
 			switch (p->op) {
 			case '=':
 				output (" == 0");
@@ -4404,9 +4409,15 @@ output_cond (cb_tree x, const int save_flag)
 			break;
 		}
 		break;
+	}
 	case CB_TAG_FUNCALL:
 		if (save_flag) {
-			output ("(ret = ");
+			/* handle original swapped function */
+			if (save_flag == 2) {
+				output ("(ret = -");
+			} else {
+				output ("(ret = ");
+			}
 		}
 		output_funcall (x);
 		if (save_flag) {
@@ -4415,7 +4426,12 @@ output_cond (cb_tree x, const int save_flag)
 		break;
 	case CB_TAG_LIST:
 		if (save_flag) {
-			output ("(ret = ");
+			/* handle original swapped function */
+			if (save_flag == 2) {
+				output ("(ret = -");
+			} else {
+				output ("(ret = ");
+			}
 		}
 		inside_stack[inside_check++] = 0;
 		/* LCOV_EXCL_START */
@@ -4443,6 +4459,7 @@ output_cond (cb_tree x, const int save_flag)
 		CB_TREE_TAG_UNEXPECTED_ABORT (x);
 	/* LCOV_EXCL_STOP */
 	}
+
 	in_cond = 0;
 }
 

cobc/tree.h

@@ -1213,30 +1213,35 @@ struct cb_reference {
 
 /* Binary operation */
 
-/*
-  '+'	x + y
-  '-'	x - y
-  '*'	x * y
-  '/'	x / y
-  '^'	x ** y
-  '='	x = y
-  '>'	x > y
-  '<'	x < y
-  '['	x <= y
-  ']'	x >= y
-  '~'	x != y
-  '!'	not x
-  '&'	x and y
-  '|'	x or y
-  '@'	( x )
-*/
+enum cb_binary_op_op {
+	BOP_PLUS	= '+',	/* x + y */
+	BOP_MINUS	= '-',	/* x - y */
+	BOP_MULT	= '*',	/* x * y */
+	BOP_DIV		= '/',	/* x / y */
+	BOP_POW 	= '^',	/* x ** y */
+	BOP_EQ		= '=',	/* x = y */
+	BOP_GT		= '>',	/* x > y */
+	BOP_LT		= '<',	/* x < y */
+	BOP_LE		= '[',	/* x <= y */
+	BOP_GE		= ']',	/* x >= y */
+	BOP_NE		= '~',	/* x != y */
+	BOP_NOT		= '!',	/* not x */
+	BOP_AND		= '&',	/* x and y */
+	BOP_OR		= '|',	/* x or y */
+	BOP_PARENS	= '@'	/* ( x ) */
+};
+
+enum cb_binary_op_flag {
+	BOP_RESOLVE_AS_INTEGER = 1,
+	BOP_OPERANDS_SWAPPED = 2
+};
 
 struct cb_binary_op {
 	struct cb_tree_common	common;		/* Common values */
 	cb_tree			x;		/* LHS */
 	cb_tree			y;		/* RHS */
-	int			op;		/* Operation */
-	unsigned int		flag;		/* Special usage */
+	enum cb_binary_op_op	op;		/* Operation */
+	enum cb_binary_op_flag 	flag;		/* Special usage */
 };
 
 #define CB_BINARY_OP(x)		(CB_TREE_CAST (CB_TAG_BINARY_OP, struct cb_binary_op, x))

cobc/typeck.c

@@ -2457,9 +2457,10 @@ cb_build_identifier (cb_tree x, const int subchk)
 	}
 
 	for (l = r->subs; l; l = CB_CHAIN (l)) {
-		if (CB_BINARY_OP_P (CB_VALUE (l))) {
+		cb_tree val = CB_VALUE (l);
+		if (CB_BINARY_OP_P (val)) {
 			/* Set special flag for codegen */
-			CB_BINARY_OP(CB_VALUE(l))->flag = 1;
+			CB_BINARY_OP (val)->flag = BOP_RESOLVE_AS_INTEGER;
 		}
 	}
 
@@ -6923,6 +6924,8 @@ swap_condition_operands (struct cb_binary_op *p)
 {
 	cb_tree y = p->x;
 
+	p->flag = BOP_OPERANDS_SWAPPED;
+
 	p->x = p->y;
 	p->y = y;
 
@@ -7018,6 +7021,9 @@ cb_build_cond (cb_tree x)
 			}
 			ret = cb_build_cond_default (p, p->x, p->y);
 			ret = cb_build_binary_op (ret, p->op, p->y);
+			if (CB_VALID_TREE (ret)) {
+				CB_BINARY_OP (ret)->flag = p->flag;
+			}
 		}
 		if (ret != cb_true && ret != cb_false) {
 			cb_copy_source_reference (ret, x);