refactor: function based transformer presets

packages/core/lib/bundler/helpers/internal.ts

@@ -3,6 +3,7 @@ import { getPreludeScript } from '@react-native-esbuild/internal';
 import {
   stripFlowWithSucrase,
   minifyWithSwc,
+  swcPresets,
 } from '@react-native-esbuild/transformer';
 import type { BundleOptions } from '@react-native-esbuild/config';
 
@@ -22,11 +23,7 @@ export const getTransformedPreludeScript = async (
     .trim();
 
   return bundleOptions.minify
-    ? minifyWithSwc(strippedScript, context, {
-        compress: true,
-        mangle: true,
-        sourceMap: false,
-      })
+    ? minifyWithSwc(strippedScript, context, swcPresets.getMinifyPreset())
     : strippedScript;
 };
 

packages/jest/lib/transformer/createTransformer.ts

@@ -34,13 +34,13 @@ export const createTransformer = (config: TransformerConfig): Transformer => {
   const syncTransformPipeline = new SyncTransformPipeline.builder(
     ROOT,
     DUMMY_ENTRY,
-    {
-      swc: swcPresets.getJestOptions({
+  )
+    .setSwcPreset(
+      swcPresets.getJestPreset({
         module: 'cjs',
         experimental: swcExperimentalOptions,
       }),
-    },
-  )
+    )
     .setInjectScripts([getReactNativeInitializeCore(ROOT)])
     .setFullyTransformPackages(transformer?.fullyTransformPackageNames ?? [])
     .setStripFlowPackages(transformer?.stripFlowPackageNames ?? [])
@@ -55,14 +55,14 @@ export const createTransformer = (config: TransformerConfig): Transformer => {
   const asyncTransformPipeline = new AsyncTransformPipeline.builder(
     ROOT,
     DUMMY_ENTRY,
-    {
+  )
+    .setSwcPreset(
       // Async transform is always ESM.
-      swc: swcPresets.getJestOptions({
+      swcPresets.getJestPreset({
         module: 'esm',
         experimental: swcExperimentalOptions,
       }),
-    },
-  )
+    )
     .setInjectScripts([getReactNativeInitializeCore(ROOT)])
     .setFullyTransformPackages(transformer?.fullyTransformPackageNames ?? [])
     .setStripFlowPackages(transformer?.stripFlowPackageNames ?? [])

packages/plugins/lib/reactNativeRuntimeTransformPlugin/reactNativeRuntimeTransformPlugin.ts

@@ -8,6 +8,7 @@ import {
 import { getReactNativeInitializeCore } from '@react-native-esbuild/internal';
 import {
   AsyncTransformPipeline,
+  swcPresets,
   type AsyncTransformStep,
 } from '@react-native-esbuild/transformer';
 import { logger } from '../shared';
@@ -121,6 +122,7 @@ export const createReactNativeRuntimeTransformPlugin: ReactNativeEsbuildPluginCr
       context.root,
       context.entry,
     )
+      .setSwcPreset(swcPresets.getReactNativeRuntimePreset())
       .setInjectScripts(injectScriptPaths)
       .setFullyTransformPackages(fullyTransformPackageNames)
       .setStripFlowPackages(stripFlowPackageNames)

packages/transformer/lib/helpers/transformer.ts

@@ -9,14 +9,16 @@ import type {
   TransformerContext,
   SwcTransformRule,
   BabelTransformRule,
+  TransformerOptionsPreset,
 } from '../types';
 
-const getOptions = <T>(
+const ruleOptionsToPreset = <T>(
   options: TransformRuleBase<T>['options'],
   code: string,
-  context: TransformerContext,
-): T => {
-  return options instanceof Function ? options(context.path, code) : options;
+): TransformerOptionsPreset<T> => {
+  return options instanceof Function
+    ? (context) => options(context.path, code)
+    : () => options;
 };
 
 export const transformByBabelRule = (
@@ -25,7 +27,7 @@ export const transformByBabelRule = (
   context: TransformerContext,
 ): Promise<string | null> => {
   return rule.test(context.path, code)
-    ? transformWithBabel(code, context, getOptions(rule.options, code, context))
+    ? transformWithBabel(code, context, ruleOptionsToPreset(rule.options, code))
     : Promise.resolve(null);
 };
 
@@ -38,7 +40,7 @@ export const transformSyncByBabelRule = (
     ? transformSyncWithBabel(
         code,
         context,
-        getOptions(rule.options, code, context),
+        ruleOptionsToPreset(rule.options, code),
       )
     : null;
 };
@@ -49,7 +51,7 @@ export const transformBySwcRule = (
   context: TransformerContext,
 ): Promise<string | null> => {
   return rule.test(context.path, code)
-    ? transformWithSwc(code, context, getOptions(rule.options, code, context))
+    ? transformWithSwc(code, context, ruleOptionsToPreset(rule.options, code))
     : Promise.resolve(null);
 };
 
@@ -62,7 +64,7 @@ export const transformSyncBySwcRule = (
     ? transformSyncWithSwc(
         code,
         context,
-        getOptions(rule.options, code, context),
+        ruleOptionsToPreset(rule.options, code),
       )
     : null;
 };

packages/transformer/lib/pipelines/AsyncTransformPipeline.ts

@@ -45,7 +45,7 @@ export class AsyncTransformPipelineBuilder extends TransformPipelineBuilder<
             code: await transformWithBabel(
               code,
               this.getTransformContext(args),
-              { root: this.root, babelrc: true },
+              this.presets.babelFullyTransform,
             ),
             // skip other transformations when fully transformed
             done: true,
@@ -103,7 +103,7 @@ export class AsyncTransformPipelineBuilder extends TransformPipelineBuilder<
         code: await transformWithSwc(
           code,
           this.getTransformContext(args),
-          this.transformerOptions.swc,
+          this.swcPreset,
         ),
         done: true,
       };

packages/transformer/lib/pipelines/SyncTransformPipeline.ts

@@ -42,10 +42,11 @@ export class SyncTransformPipelineBuilder extends TransformPipelineBuilder<
       pipeline.addStep((code, args) => {
         if (fullyTransformPackagesRegExp.test(args.path)) {
           return {
-            code: transformSyncWithBabel(code, this.getTransformContext(args), {
-              root: this.root,
-              babelrc: true,
-            }),
+            code: transformSyncWithBabel(
+              code,
+              this.getTransformContext(args),
+              this.presets.babelFullyTransform,
+            ),
             // skip other transformations when fully transformed
             done: true,
           };
@@ -102,7 +103,7 @@ export class SyncTransformPipelineBuilder extends TransformPipelineBuilder<
         code: transformSyncWithSwc(
           code,
           this.getTransformContext(args),
-          this.transformerOptions.swc,
+          this.swcPreset,
         ),
         done: true,
       };

packages/transformer/lib/pipelines/builder.ts

@@ -1,12 +1,12 @@
 import type { OnLoadArgs } from 'esbuild';
 import type { Options as SwcTransformOptions } from '@swc/core';
-import type { TransformOptions as BabelTransformOptions } from '@babel/core';
 import type {
   BabelTransformRule,
   SwcTransformRule,
   TransformStep,
+  TransformerOptionsPreset,
 } from '../types';
-import { babelPresets, swcPresets } from '../transformer';
+import { babelPresets } from '../transformer';
 import type { TransformPipeline } from './pipeline';
 
 const FLOW_SYMBOL = ['@flow', '@noflow'] as const;
@@ -15,12 +15,12 @@ export abstract class TransformPipelineBuilder<
   Step extends TransformStep<unknown>,
   Pipeline extends TransformPipeline<Step>,
 > {
+  protected presets = {
+    babelFullyTransform: babelPresets.getFullyTransformPreset(),
+  };
   protected onBefore?: Step;
   protected onAfter?: Step;
-  protected transformerOptions: {
-    swc?: SwcTransformOptions;
-    babel?: BabelTransformOptions;
-  } = {};
+  protected swcPreset?: TransformerOptionsPreset<SwcTransformOptions>;
   protected injectScriptPaths: string[] = [];
   protected fullyTransformPackageNames: string[] = [];
   protected stripFlowPackageNames: string[] = [];
@@ -30,16 +30,7 @@ export abstract class TransformPipelineBuilder<
   constructor(
     protected root: string,
     protected entry: string,
-    transformerOptions?: {
-      swc?: SwcTransformOptions;
-      babel?: BabelTransformOptions;
-    },
-  ) {
-    this.transformerOptions.swc =
-      transformerOptions?.swc ?? swcPresets.getReactNativeRuntimeOptions();
-    this.transformerOptions.babel =
-      transformerOptions?.babel ?? babelPresets.getCommon();
-  }
+  ) {}
 
   protected getNodePackageRegExp(packageNames: string[]): RegExp | null {
     return packageNames.length
@@ -106,5 +97,12 @@ export abstract class TransformPipelineBuilder<
     return this;
   }
 
+  public setSwcPreset(
+    preset: TransformerOptionsPreset<SwcTransformOptions>,
+  ): this {
+    this.swcPreset = preset;
+    return this;
+  }
+
   abstract build(): Pipeline;
 }

packages/transformer/lib/transformer/babel/babel.ts

@@ -1,7 +1,7 @@
 import type { TransformOptions } from '@babel/core';
 import { loadOptions, transformAsync, transformSync } from '@babel/core';
 import type {
-  Transformer,
+  AsyncTransformer,
   SyncTransformer,
   TransformerContext,
 } from '../../types';
@@ -17,12 +17,12 @@ const loadBabelOptions = (
   });
 };
 
-export const transformWithBabel: Transformer<TransformOptions> = async (
+export const transformWithBabel: AsyncTransformer<TransformOptions> = async (
   code: string,
   context,
-  options,
+  preset,
 ) => {
-  const babelOptions = loadBabelOptions(context, options);
+  const babelOptions = loadBabelOptions(context, preset?.(context));
   if (!babelOptions) {
     throw new Error('cannot load babel options');
   }
@@ -38,9 +38,9 @@ export const transformWithBabel: Transformer<TransformOptions> = async (
 export const transformSyncWithBabel: SyncTransformer<TransformOptions> = (
   code: string,
   context,
-  options,
+  preset,
 ) => {
-  const babelOptions = loadBabelOptions(context, options);
+  const babelOptions = loadBabelOptions(context, preset?.(context));
   if (!babelOptions) {
     throw new Error('cannot load babel options');
   }

packages/transformer/lib/transformer/babel/presets.ts

@@ -1,11 +1,22 @@
 import type { TransformOptions } from '@babel/core';
+import type { TransformerOptionsPreset } from '../../types';
 
-const getCommon = (): TransformOptions => ({
-  minified: false,
-  compact: false,
-  sourceMaps: false,
-  babelrc: false,
-  highlightCode: !process.stdin.isTTY,
-});
+const getCommonPreset = (): TransformerOptionsPreset<TransformOptions> => {
+  return (_context) => ({
+    minified: false,
+    compact: false,
+    sourceMaps: false,
+    babelrc: false,
+    highlightCode: !process.stdin.isTTY,
+  });
+};
 
-export { getCommon };
+const getFullyTransformPreset =
+  (): TransformerOptionsPreset<TransformOptions> => {
+    return (context) => ({
+      root: context.root,
+      babelrc: true,
+    });
+  };
+
+export { getCommonPreset, getFullyTransformPreset };