Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent unnecessary nft requerying #377

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix: prevent unnecessary nft requerying #377

merged 1 commit into from
Aug 19, 2024

Conversation

alter-eggo
Copy link
Contributor

This pr prevents re-querying of nft metadata using only useQuery, without keeping ids in store like here leather-io/extension#5747

@alter-eggo alter-eggo requested a review from kyranjamie August 19, 2024 12:27
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a more simple solution than what I'd proposed with a new slice 👍🏼

@alter-eggo alter-eggo marked this pull request as ready for review August 19, 2024 12:55
@alter-eggo alter-eggo added this pull request to the merge queue Aug 19, 2024
Merged via the queue into dev with commit 06603c9 Aug 19, 2024
9 checks passed
@alter-eggo alter-eggo deleted the fix/nft-queries branch August 19, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants