refactor: upgrade stacks js, closes LEA-1989

[fbwoolf]

Building Leather at commit b299345

Upgrades all stacks.js pkgs to 7.0.2.

[linear]

LEA-1989 Upgrade stacks.js in extension

[fbwoolf]

Dependent on changes installed from here: leather-io/mono#796

[fbwoolf]

@kyranjamie I'm testing the changes here, but can you look over my changes to the stacks private and public key code changes? And, stacks.js removed decrypt and encrypt. I replaced them with decryptMnemonic and encryptMnemonic from @stacks/encryption, but I'm not sure if that is correct? There wasn't instruction in the migration doc. 🤔

[kyranjamie]

I replaced them with decryptMnemonic and encryptMnemonic from @stacks/encryption, but I'm not sure if that is correct? There wasn't instruction in the migration doc. 🤔

I'll get to testing this when I've fixed some tests for the returning txid issue. But re this, I'd make sure they're backwards compatible. Do these new methods decrypt payloads made before v7? Pretty sure they won't, so then we'll have to have some migration step, or bring over the old encryption methods from v6.

[fbwoolf]

I'll get to testing this when I've fixed some tests for the returning txid issue. But re this, I'd make sure they're backwards compatible. Do these new methods decrypt payloads made before v7? Pretty sure they won't, so then we'll have to have some migration step, or bring over the old encryption methods from v6.

I tested going from dev > to this branch, creating a wallet > locking > then unlocking each way and did not hit any errors. Would love for you to test too though just to make sure works on your end. Maybe the change is ok? https://github.com/hirosystems/stacks.js/blob/main/.github/MIGRATION.md#triplesec

EDIT: This was the code removed with aliased methods:
https://www.npmjs.com/package/@stacks/wallet-sdk/v/6.15.0?activeTab=code

[fbwoolf]

Something isn't quite right bc running into this restoring the test wallet. Balances are correct, but BNS name lookup is incorrect and appears to only restore one account. Looking into it...

EDIT: Loading, but a few BNS names are funky 🤔

EDIT: This appears to actually be a bug with BNS changes in the mono repo upgrade, so looking at fixing there.

[fbwoolf]

@kyranjamie all seems to be working when I test now so opening up for your code review. Tests will be broken until I actually install mono repo changes, but hoping you will look over when can.

[kyranjamie]

Alright let's try getting this out the door. Testing this now with changes you've also pushed to mono 👨🏼‍💻

[fbwoolf]

Alright let's try getting this out the door. Testing this now with changes you've also pushed to mono 👨🏼‍💻

I ran into an issue last night trying to do a swap. Bc Bitflow sends us ClarityValues from 6.17.0, when we serialize we get an error.

[fbwoolf]

@kyranjamie I'm working to get all the failing tests passing locally for me. The new encryption test you added is failing here when running it with the other onboarding tests, but it passes when run via .only, and this is the same for if I copy the test and run it on current dev branch, am I missing something or is the test maybe not a valid test?

EDIT: ^ this screenshot is the failure on dev branch.

[kyranjamie]

@fbwoolf taking a look now, not clear why this would cause the step to fail

[fbwoolf]

@fbwoolf taking a look now, not clear why this would cause the step to fail

I think after some testing, my last commit is right? We have to sign in with the test user so it uses the same salt and set the encryptionKey we know is correct > then lock/unlock the wallet using the new encryption code > check if the new set encryptionKey in storage is equal? It does pass.

[fbwoolf]

@kyranjamie I'm looking into these type errors, but I think maybe came from your changes in rpc pkg?