ci: upgrade upload-actifact@v4 #6075
Merged
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
ci/upgrade-upload-artifact
branch
2 times, most recently
from
afc235b to
020cb4e
Compare
|
I think we should prioritize getting this merged? |
camerow
approved these changes
Jan 23, 2025
|
Deliberately or not they deprecated this early and this is currently breaking our pipeline. Merging to unblock @fbwoolf PR. |
kyranjamie
force-pushed
the
ci/upgrade-upload-artifact
branch
from
020cb4e to
8a1219d
Compare
|
Yeah weird, alright let's merge this now—but aim to do a release Monday to verify the create release job works properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't addressed any of the breaking changes yet, but making PR to see debug
This PR should be merged before a non-urgent release as the release jobs also need to be tested