fix rendering the correct src20 image, closes LEA-1993 #6063
+42
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camerow
force-pushed
the
will/fix-src20-image
branch
from
a15c45c to
3727275
Compare
fbwoolf
reviewed
Jan 16, 2025
camerow
force-pushed
the
will/fix-src20-image
branch
from
cfe5baf to
cbfd89b
Compare
fbwoolf
approved these changes
Jan 16, 2025
camerow
force-pushed
the
will/fix-src20-image
branch
from
cbfd89b to
d300bf9
Compare
|
I see now. |
fbwoolf
reviewed
Jan 16, 2025
| const [isLoading, setIsLoading] = useState(true); | ||
| const [width, setWidth] = useState(0); | ||
|
|
||
| if (isError) return <Src20AvatarIcon width="xl" />; |
There was a problem hiding this comment.
I don't think you want to resize the icon here?
There was a problem hiding this comment.
@camerow I would move this file out of collectibles bc being used in the asset list?
There was a problem hiding this comment.
Yeah it seems to make no difference if I resize it or not (perhaps that's the default size).
I can move it, should I move to a new /components/src20/src20-image.tsx or just put it in the src20-tokens-asset-list?
There was a problem hiding this comment.
Updated the location, let me know if it looks ok to you.
camerow
force-pushed
the
will/fix-src20-image
branch
from
d300bf9 to
0a41114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically fixes the layout of the SRC-20 tokens in this list (before / after use different tokens, but the change is applied to any SRC-20)
Before:
After: