Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display proper image for src20 tokens #6009

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

RisingStarDev
Copy link

No description provided.

@kyranjamie
Copy link
Collaborator

Thanks for the contribution @RisingStarDev — Code LGTM. We'll clone this PR so the CI runs

@pete-watters
Copy link
Contributor

Thanks for your work @RisingStarDev 👏 There are some CI errors in your code, can you please check them out?

They relate to:

  • types
  • prettier formatting
  • dependancy importing

@RisingStarDev
Copy link
Author

image

Thanks for checking my work. @kyranjamie

The CI errors are Property 'deploy_img' does not exist on type 'Src20CryptoAssetInfo'.

I've already submitted an issue on the leather-io/mono repo to update Src20CryptoAssetInfo to include deploy_img props.

leather-io/mono#724

@kyranjamie, Can you please check the issue I submitted on the leather-io/mono repo and update the module?

Then I think this PR will work fine.

Thank you.

@pete-watters
Copy link
Contributor

leather-io/mono#724

Thanks @RisingStarDev 👍 I opened this PR to add the types. I'll get that released and then we can update the package and get this work merged.

Can you look at the prettier + dependancy issue in the meantime?
Screenshot 2024-12-19 at 06 30 13
Screenshot 2024-12-19 at 06 30 03

@pete-watters
Copy link
Contributor

@RisingStarDev I updated the libraries you need in #6031 so you should be able to rebase and finish this off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants