fix(ledger): legacy auth flow #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
approved these changes
Dec 12, 2024
alter-eggo
approved these changes
Dec 12, 2024
314159265359879
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd removed the Ledger signing flow from auth, forgot that we actually signed the JWT with the device.
Here, the animation doesn't really make sense, as it runs before the modal opens to do the sign operation. I wonder if this is worth fixing? It's not ideal, but seems very low impact to fix, given this is a now-depreacted API.
2024-12-12-000378.mp4
cc/ @314159265359879