fix(ledger): support stx_signMessage #5757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-watters
approved these changes
Aug 15, 2024
kyranjamie
force-pushed
the
fix/stacks-ledger
branch
2 times, most recently
from
9099a24 to
c463e09
Compare
alter-eggo
approved these changes
Aug 15, 2024
kyranjamie
force-pushed
the
fix/stacks-ledger
branch
from
c463e09 to
30288c0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5756
This PR adds support for Ledger on the
stx_signMessageRPC call. A user reported this not working, and it's quite a crucial feature, and provides better compatibility between wallets.