fix: incessant requerying of nfts with missing metadata #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
fix/dead-nft-queries
branch
from
1fbc7c1 to
4b54db2
Compare
alter-eggo
approved these changes
Aug 9, 2024
| @@ -18,7 +16,13 @@ interface StacksCryptoAssetsProps { | |||
| export function StacksCryptoAssets({ address }: StacksCryptoAssetsProps) { | |||
| const names = useGetBnsNamesOwnedByAddressQuery(address).data?.names; | |||
|
|
|||
| const stacksNftsMetadataResp = useStacksNonFungibleTokensMetadata(address); | |||
| // NftMetadataResponse[] | |||
There was a problem hiding this comment.
this should be removed I believe?
|
@alter-eggo to implement similar solution for FTs to compare with this PR |
|
@alter-eggo do you think this is OK to merge and get released? Once we remove this code |
|
@pete-watters I think we can close this pr |
We can merge it? Or just close it as the work is no longer needed? |
|
@pete-watters just closed, problem is resolved here leather-io/mono#377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some state to prevent requerying of metadata when we know that it isn't, and won't, be there in future. This'll save loads of requests to Hiro's APIs.
This PR only tackles NFTs. Perhaps you can follow up doing the same with FTs @alter-eggo?
Adding this highlights some of the failures of the query package, I think. For example, the "query hook" in question was actually a wrapper hook, preventing accessing the internals. A rule for query package should be that ONLY options creator functions are returned. I think we shouldn't even return wrapped
useQueriesas it get confusing when we need to create an app-specific clone of same name.Before
2024-08-09-000266.mp4
After
Now only has FT missing queries
2024-08-09-000267.mp4