Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: readd fragments to help escape single quote #5722

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Aug 2, 2024

Try out Leather build 433dba8Extension build, Test report, Storybook, Chromatic

I hastily removed what seemed un-necessary fragments yesterday but that actually creates a panda build error:

🐼 error [sheet:process] > 1 | .leather-content_You\'ll_need_it_to_access_your_wallet_on_a_new_device\,_or_this_one_if_you_lose_your_password_—_so_back_it_up_somewhere_safe\! {content: You'll need it to access your wallet on a new device, or this one if you lose your password — so back it up somewhere safe !important;
    |                                                                                                                                                              ^
  2 | }
  3 | 
🐼 error [sheet:process] > 1 | .leather-content_Your_password_protects_your_Secret_Key_on_this_device_only\._To_access_your_wallet_on_another_device\,_you\'ll_need_just_your_Secret_Key\. {content: Your password protects your Secret Key on this device only. To access your wallet on another device, you'll need just your Secret Key.;

I tried a few things to escape the ' but it seems easier and cleaner to just keep them as fragments

@alter-eggo alter-eggo added this pull request to the merge queue Aug 6, 2024
Merged via the queue into dev with commit 8ac4349 Aug 6, 2024
31 checks passed
@alter-eggo alter-eggo deleted the chore/fix-panda-build-error branch August 6, 2024 11:19
@kyranjamie
Copy link
Collaborator

Curious how this didn't break the CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants