Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade storybook v8, enable visual tests #5103

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Upgrade storybook v8, enable visual tests #5103

merged 2 commits into from
Mar 19, 2024

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Mar 19, 2024 •
edited
Loading

Try out Leather build 07ad576 — Extension build, Test report, Storybook, Chromatic

This PR

  • Updates Storybook to version 8, see announcement →
  • Re-enables Chromatic tests
    • Any runs from main/dev are auto-accepted as the latest version
    • Adds Chromatic link to PR links
    • Moves Chromatic action back to separate job. There are permalinks we can use, preventing need to wait for chromatic to finish to update msg
image

@kyranjamie kyranjamie changed the title Chore/upgrade storybook Upgrade storybook v8, enable visual tests Mar 19, 2024
@kyranjamie kyranjamie force-pushed the chore/upgrade-storybook branch 9 times, most recently from e696bdf to 8439c1d Compare March 19, 2024 18:24
@kyranjamie kyranjamie force-pushed the chore/upgrade-storybook branch from 8439c1d to 07ad576 Compare March 19, 2024 18:37
@kyranjamie kyranjamie requested a review from fbwoolf March 19, 2024 18:38
@kyranjamie kyranjamie marked this pull request as ready for review March 19, 2024 18:44
@kyranjamie kyranjamie requested a review from alter-eggo March 19, 2024 18:46
@kyranjamie kyranjamie added this pull request to the merge queue Mar 19, 2024
Merged via the queue into dev with commit 3ed207f Mar 19, 2024
30 checks passed
@kyranjamie kyranjamie deleted the chore/upgrade-storybook branch March 19, 2024 19:26
@kyranjamie kyranjamie mentioned this pull request Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbwoolf fbwoolf fbwoolf approved these changes

@alter-eggo alter-eggo Awaiting requested review from alter-eggo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyranjamie @fbwoolf