-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate shopping cart into lesson resource selection side panel #12996
base: develop
Are you sure you want to change the base?
Integrate shopping cart into lesson resource selection side panel #12996
Conversation
@@ -0,0 +1,263 @@ | |||
<template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isnt actually a completely new file, this was moved from https://github.com/learningequality/kolibri/pull/12996/files#diff-31fd90e627499b35b0a5e2f15e2b3fb570cb32543799343fd4549daf91bbe2a4
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes from an initial read through - I'll do a second review tomorrow. I also haven't run this locally yet or tried it out.
@pcenov I'll add you here for manual QA - please let me or Alex know if you have any questions about how to test these changes. Thank you!
...oach/assets/src/views/lessons/LessonSummaryPage/sidePanels/LessonResourceSelection/index.vue
Show resolved
Hide resolved
...oach/assets/src/views/lessons/LessonSummaryPage/sidePanels/LessonResourceSelection/index.vue
Show resolved
Hide resolved
...oach/assets/src/views/lessons/LessonSummaryPage/sidePanels/LessonResourceSelection/index.vue
Outdated
Show resolved
Hide resolved
...oach/assets/src/views/lessons/LessonSummaryPage/sidePanels/LessonResourceSelection/index.vue
Outdated
Show resolved
Hide resolved
Hi @AlexVelezLl and @marcellamaki, I confirm that this is implemented as specified above. Noticed the following potential issues:
Current implementation: selection.mp4Previous: previous.mp4
cannot.preview.a.resource.mp4
the.back.arrow.mp4 |
68422bf
to
58f9ff6
Compare
I think this is desirable - with one change from the previous behaviour - the checkboxes should be marked as selected, but disabled. This is an intentional change we introduced in the quiz workflow, so that resource selection was a 'shopping cart' experience - going to find new resources to include - not a selection and deselection experience. Removing resources is done from the lesson itself, not the resource selection flow. |
For 2 - we have two follow up issues for the preview behaviours, so yes, I think out of scope for this PR! #12988 and #12989 For 3 - my understanding is that this is currently intended behaviour. I think we shouldn't block the PR for this, and I know there are other back arrow confusions in resource selection in quiz too, so we should keep a close eye on people's reactions to this as we do broader internal testing. |
Thank @rtibbles! I have pushed the changes to have these checkboxes selected but disabled :) Compartir.pantalla.-.2025-01-24.09_04_54.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AlexVelezLl - I confirm that the checkboxes of the already added resources are disabled now.
Summary
Compartir.pantalla.-.2025-01-13.16_12_02.mp4
References
Closes #12990.
Reviewer guidance
Implementation notes
As we shouldnt have repeated resources in a lesson, I have make sure to save unique resoures in the list. This implies that if a user is selecting a resource that is already in the lesson, it will just "ignore" it (because of the unification process). So it wont take it into account to make the save request, neither to show the close confirmation message if no new resources are being added. Does this makes sense?