Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing in Xcode - Adding to Swift.md #170

Merged
merged 11 commits into from
Nov 25, 2023

Conversation

NonLan
Copy link
Contributor

@NonLan NonLan commented Nov 23, 2023

Went into testing in Xcode in more detail.

Specifically added information about unit testing, simulators, and debugging.

@NonLan
Copy link
Contributor Author

NonLan commented Nov 23, 2023

Hey guys, thanks for looking over my PR, I'd appreciate any comments on where I might be able to improve!

I'm primarily wondering whether I included enough information for each section, notably Unit Tests, Simulators, and Debugging. I tried to link to Apple's documentation where there might be a significant overlap between what I write and what is already available from Apple. That being said, please let me know if there's anything that's unclear or anything I should expand on.

As well, I did take some screenshots of the Xcode window on my Mac to show, for example, what the Xcode window looks like in debugging mode. I did not include them in this PR because I thought it did not really add much to the content, since it really just shows what the window layout looks like when you select different options. Would it be better if I included some screenshots, and if so, where would be best?

@NonLan NonLan requested a review from thakshaCS November 23, 2023 15:55
Copy link
Collaborator

@alyson647 alyson647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about unit tests or debugging in Xcode, but I think your article is informative on the different ways you can test your app! I like that you emphasized some terms using ``, especially when writing out instructions. I also like the embedded links in your sentences.
You mentioned in your comment that you weren't sure if you should add images to your article. Adding images wouldn't hurt! It would help in breaking up longer sections of text. Adding the debugging mode image would aid the reader in having a visual to refer to. If it were someone who doesn't have any experience in Xcode, I think it would be beneficial to them to have a visual. As well, for the section on unit tests, maybe you could add an example of what a simple unit test looks like in Swift. Just to give an example of what the format might be in the Swift language.

@thakshaCS
Copy link
Contributor

Hey Noelle,

I think your "Testing Your App" - Simulators: Setup section is written very well and has clear instructions on how add a simulator. For that section I don't think pictures are necessary because the instructions provided are simple and easy to follow.

In the section "Testing Your App - Simulators: Interactions" its good that you included notable features as these features seem like what most 301 students would use when creating their project in swift and gives them an idea of extensibility of swift from Face ID to setting the location.

I think you have written a very informative and well organized the information. To answer you questions about pictures, I dont think its necessary because you included links so people reading can find out more about how to do what you mentioned and those links contain pictures.

@NonLan
Copy link
Contributor Author

NonLan commented Nov 24, 2023

Thanks for the feedback! Based on what you guys said, I'm thinking I'll add a screenshot for each subsection over the weekend/later today (specifically the debugging window and a sample unit test).

@NonLan NonLan merged commit 1f40a52 into learning-software-engineering:main Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants