Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unity Intro #149

Merged

Conversation

ruiting-chen
Copy link
Contributor

@ruiting-chen ruiting-chen commented Nov 21, 2023

Added page for a basic introduction to Unity
Information on the page includes:

  • Download and install Unity Hub and Unity Editor, Licensing
  • Create a new Unity project
  • Unity user interface

@arielchen07 please review

@arielchen07
Copy link
Contributor

arielchen07 commented Nov 24, 2023

Hi! This is great introduction to Unity in general!
I really like the picture for explaining the interface. It's really intuitive and easy for beginners to understand!
Except the suggestion to bold some keywords, i would also recommend to add a section at the end to briefly talk about how to start making the game or just link to some videos. By doing this, the readers will know what to do after they finish setting up and familiarized with Unity.

@arielchen07
Copy link
Contributor

I just read your comments on my Pull Request and yes, I would also recommend you adding a table of contents at the start of the page like i did!

@ruiting-chen
Copy link
Contributor Author

I bolded keywords in my doc and also added a table of contents section.

I think it's a good idea to add a section to talk about how to start making games at the end, to transition readers to start making something useful with Unity. However I think it would be kind of broad to talk about how to start making games in Unity in general. And there will be a lot stuff to write about which will make this doc very long. So I think I will provide links to tutorial video series that demonstrates how to make simple 2D and 3D games in Unity.

@arielchen07
Copy link
Contributor

Great! I think referring the readers to some videos is a great idea here! We can just keep this page clean and only focus on some basics.

@arielchen07
Copy link
Contributor

I've reread your page after you modified and I left some comments on some other parts. Could you take a look and let me know what you think

@ruiting-chen
Copy link
Contributor Author

I added a section for how to get started with making your first Unity game and provided video links for making 2D and 3D games.
I also changed the title of the page to be more precise. Please review the changes and let me know your thoughts

@arielchen07
Copy link
Contributor

I notice that you cannot see my newly-added comments, so I attached the screenshots here.
Screenshot 2023-11-26 at 7 30 57 PM
Screenshot 2023-11-26 at 7 31 04 PM
Screenshot 2023-11-26 at 7 31 11 PM

I reviewed your new changes, it seems that you fixed the first and second comment that I mentioned, which is great! I also like your separate section for how to get started with making your first Unity game. It makes the whole page more structural.

By saying these, could also take a look at my comments in the third screenshot?

@ruiting-chen
Copy link
Contributor Author

ohh I see. Yeah I agree with you that the links in reference are a bit messy, I will fix that

@ruiting-chen
Copy link
Contributor Author

I updated the reference links. Please have a look and let me know how they look now

Copy link
Contributor

@arielchen07 arielchen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! It looks much organized now!


#### License Activation:
An activated license is needed to use Unity. When you sign in to the Unity Hub for the first time, you will be asked to add an active license.
At the top of Unity Hub, click "Manage licenses". If you do not see this, you can manage licenses by clicking on the preferences (or settings) icon on the top of the left tab bar beside your account icon > then select the license tab in the window that pops up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make "Manage licenses" bold here? It will be easier for reader to catch the keywords for clicking.
Same for the icons and other buttons that you mentioned below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it

@@ -0,0 +1,98 @@
# Unity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to name this page as Unity? Or do you have a better name for this?
From my understanding, this page introduce the basics of Unity, so you probably want to name it Introduction to Unity basics or something like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah your right. I updated it to "Introduction to Unity Basics"

At the top of Unity Hub, click **Manage licenses**. If you do not see this, you can manage licenses by clicking on the **Preferences (or Settings) icon** on the top of the left tab bar beside your account icon > then select the **license** tab in the window that pops up.
Click **Add** to add a new license.
You can choose to get a free personal license or get an educational (student) license by applying for the Unity student plan on [this website](https://unity.com/products/unity-student).
<img width="650" alt="image" src="https://github.com/ruiting-chen/learning-software-engineering.github.io/assets/51133017/ffddd0e9-cc10-451b-9dca-b92edee2c1bd">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some formatting issues. Could you correct it?


https://docs.unity3d.com/Manual/VisualStudioIntegration.html#:~:text=Unity%20automatically%20uses%20Visual%20Studio,into%20an%20existing%20Unity%20installation. (Unity Manual)

https://getalow.com/unity-engine/introduction-to-unity-editor-and-unity-interface/16 (Introduction to Unity Editor and Unity Interface)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the reference here, all the links seem a bit messy. Would you consider change it to hyperlinks attached to the your sentence in the brackets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the format

@arielchen07
Copy link
Contributor

One last thing before merging this PR, do we need to add the name of this page to the readme file on the wiki?

@ruiting-chen
Copy link
Contributor Author

I'm not sure if we need to add the name to the readme file. I will read the handout again. If I can't find information about it, I will ask on piazza

@arielchen07
Copy link
Contributor

I think it's in the FAQ

What are some of the best practices to keep in mind for submission?
i. Give relevant names to your commit messages
ii. Summarize your contributions in the comment section of your PR.
iii. Document your approach wherever relevant. This ensures the
ease of use and understanding of your contribution for other
students; for example, if you request changes to someone else’s
PR- clearly explain your thought process. Update the readme files
on the wiki wherever appropriate.

@ruiting-chen
Copy link
Contributor Author

yea ok I just read this. But i see that the Readme says "potential topics", so I'm not sure if it is an updated version of the topics and whether we should update here. But I will add the page name here anyways
image

I think Tech_Stacks.md is more up to date, so I will add my page name and link here
image

@ruiting-chen
Copy link
Contributor Author

I added the page name in readme and Tech_Stacks.md

@arielchen07
Copy link
Contributor

Great! I think there is no conflicts with the main branch and it is ready to merge!

@ruiting-chen
Copy link
Contributor Author

ok! i will merge the pull request now

@ruiting-chen ruiting-chen merged commit c252995 into learning-software-engineering:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants