-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added resources about WebRTC #116
Added resources about WebRTC #116
Conversation
Added description for signalling server and ICE candidates
This is looking really good David. A few comments:
|
Thanks Kai for the feedback and suggestions. Adding a diagram for ICE candidates is a great idea for better clarity and I'll expand on the SFU and MCU sections to detail their unique advantages and limitations. I'll update the PR soon with these enhancements. |
Great Work David, I think you have done a great job at explaining concepts like signalling server and ICE candidates, as well as the importance of STUN and TURN servers in ICE.
I agree with Kai that a simple diagram to explain ICE candidates would be extremely helpful, and if you have time I believe that adding quick code comments to critical parts of the code would benefit some readers, especially those who are new to coding and WebRTC as a whole! Keep up the great work!! |
Thank you Allen for the review, I have added a diagram regarding the ICE candidates and it does help the understanding a lot. |
I think the documentation on the perks and limitations of SFU and MCU is sufficient in the article. This article mainly focuses on establishing a peer-to-peer models and more details on SFU and MCU is also referenced at the end if the reader wants to learn more about different architectures. |
The PR introduces a thorough expansion to our WebRTC documentation. The update includes detailed explanations of core concepts like the signaling server, ICE candidates, STUN and TURN servers, and the nuances of establishing connections and streaming in WebRTC. Additionally, it explores alternative architectures such as SFU and MCU, addressing their scalability and applicability in different scenarios.
Key Additions:
Purpose: