Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the logging level in test_cli_scripts #617

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Conversation

mryab
Copy link
Member

@mryab mryab commented Jun 9, 2024

Currently, trying to run a test suite including test_dht_connection_successful with HIVEMIND_LOGLEVEL other than INFO can lead to intermittent failures, because the first log message might become a debug log entry. This PR overrides the environment when launching hivemind-dht from tests to make testing more straightforward

@mryab mryab requested a review from justheuristic June 9, 2024 20:30
Copy link
Member

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mryab mryab merged commit 91fa494 into master Jun 9, 2024
13 checks passed
@mryab mryab deleted the env_cli_scripts branch June 9, 2024 20:32
mryab added a commit that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants