Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pymultihash from datastructures.py #601

Merged
merged 12 commits into from
Dec 2, 2023
Merged

Conversation

dvmazur
Copy link
Collaborator

@dvmazur dvmazur commented Nov 30, 2023

This PR removes pymultihash from the codebase and dependencies as it is
in conflict with py-multihash.

@dvmazur dvmazur changed the title Test: remove pymultihash from datastructures.py Remove pymultihash from datastructures.py Dec 2, 2023
@dvmazur dvmazur requested a review from justheuristic December 2, 2023 07:23
@@ -17,25 +17,9 @@
# NOTE: On inlining...
# See: https://github.com/libp2p/specs/issues/138
# NOTE: enabling to be interoperable w/ the Go implementation
ENABLE_INLINING = True
# ENABLE_INLINING = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rm this

@dvmazur dvmazur changed the base branch from master to bump-p2pd December 2, 2023 20:17
@justheuristic justheuristic merged commit 3ccecc9 into bump-p2pd Dec 2, 2023
4 of 11 checks passed
@justheuristic justheuristic deleted the test-no-multihash branch December 2, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants