Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package namespace self-contained #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arcresu
Copy link

@arcresu arcresu commented May 23, 2023

These are the minimal changes necessary to make R CMD check pass. By explicitly specifying the namespace of functions from dependencies, users no longer have to attach the dependencies of epifish themselves. This means that a bit of boilerplate can be removed from the examples in the documentation in future.

The use of the .data pronoun is the documented way to silence warnings in R CMD check (which doesn't know about tidy evaluation and data masking) but as far as I know doesn't actually have any effect beyond that.

In any case, these changes do not affect anything at all about what the code does. While it looks like new dependencies on rlang and magrittr are added, these were already there implicitly via the usage of dplyr, so this just makes it explicit to keep R happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant