Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-publish infoview #458

Merged
merged 27 commits into from
Jun 19, 2024
Merged

Conversation

joneugster
Copy link
Contributor

@joneugster joneugster commented May 27, 2024

Automatically publish infoview and infoview-api on npmjs if the version changed.

@joneugster
Copy link
Contributor Author

joneugster commented May 27, 2024

This is a first draft, containing the modifications to publish the infoview from CI.

One needs to create an NPM access token and add it as github secret NPM_TOKEN.

This does not yet contain any version number management.

I have a hard time testing this, only did so for @leanprover/infoview but not for the infoview-api yet.

package-lock.json Outdated Show resolved Hide resolved
.github/workflows/on-push.yml Outdated Show resolved Hide resolved
.github/workflows/on-push.yml Outdated Show resolved Hide resolved
@joneugster
Copy link
Contributor Author

joneugster commented May 29, 2024

@mhuisi I think this is now one of the simplest versions I could think of. on a new release, if the package version of infoview or infoview-api changed, it will publish the new version to npmjs.

Using e.g. npm --workspace=lean4-infoview version patch to bump the version is still required to happen manually.

It does not necessarily need to be coupled to the release schedule of the VSCode-extension, but I figured doing so ensures that only maintainers will trigger the publishing (at defined steps of the procedure) and not by accident.

Note: in this CI run you can see how it tries to publish infoview but just prints a note for infoview-api. The npm error seems to be the way the say "authentification failed"

lean4-infoview/package.json Outdated Show resolved Hide resolved
@joneugster joneugster force-pushed the publish-test branch 2 times, most recently from e4a0653 to 6e11f74 Compare June 3, 2024 09:37
Copy link
Member

@Vtec234 Vtec234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it but looks good in theory!

@mhuisi mhuisi merged commit 070d284 into leanprover:master Jun 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants