feat: zetaUnused option (implementation) #6755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the `+zetaUnused` option. Implementation to follow after the stage0 update.
nomeata
added
awaiting-mathlib
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
nomeata
added
the
merge-ci
nomeata
removed
the
merge-ci
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 24, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 24, 2025
leanprover-community-bot
added
the
breaks-mathlib
leanprover-community-bot
added
builds-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 25, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 25, 2025
nomeata
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 27, 2025
jcommelin
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 30, 2025
* chore: bump to nightly-2025-01-09 * bump batteries * bump deps * fix * chore: adaptations for nightly-2025-01-09 * chore: bump to nightly-2025-01-10 * remove upstreamed * Update lean-toolchain for testing leanprover/lean4#6602 * Trigger CI for leanprover/lean4#6602 * fix breakage caused by leanprover/lean4#6602 * chore: adaptations for nightly-2025-01-10 * fix merge * avoid nonrec for leanprover/lean4#6602 * Trigger CI for leanprover/lean4#6602 * chore: bump to nightly-2025-01-14 * bump * fixes * fixes * fixes * chore: bump to nightly-2025-01-15 * fix * empty commit to bump CI * Update lean-toolchain for testing leanprover/lean4#6660 * fixes for leanprover/lean4#6660 * chore: bump to nightly-2025-01-16 * . * fix * chore: bump to nightly-2025-01-17 * deprecation * chore: bump to nightly-2025-01-18 * Merge master into nightly-testing * chore: bump to nightly-2025-01-19 * fix * chore: bump to nightly-2025-01-20 * fix and bump * bump ProofWidgets * chore: bump to nightly-2025-01-21 * bump * Adaptations * fixes * fix * fix * chore: bump to nightly-2025-01-22 * chore: adaptations for nightly-2025-01-22 * remove deprecation for List.indexOf_lt_length * chore: bump to nightly-2025-01-23 * chore: bump to nightly-2025-01-24 * Adjust expected output in MathlibTest.CountHeartbeats * chore: adaptations for nightly-2025-01-24 * chore: bump to nightly-2025-01-25 * chore: bump to nightly-2025-01-26 * chore: bump to nightly-2025-01-27 * Merge master into nightly-testing * Adaption for leanprover/lean4#6755 * Update lean-toolchain for testing leanprover/lean4#6800 * lake update for leanprover/lean4#6800 * Trigger CI for leanprover/lean4#6800 * fixes for leanprover/lean4#6800 * Trigger CI for leanprover/lean4#6800 * fix * Update lean-toolchain for testing leanprover/lean4#6812 * chore: bump to nightly-2025-01-28 * lake update for leanprover/lean4#6812 * TrivSqZeroExt.snd_list_prod fix * Update lean-toolchain for testing leanprover/lean4#6826 * Adaption * fix * fix * remove deprecation/alias * touch for CI for leanprover/lean4#6812 * fix for leanprover/lean4#6812 * Trigger CI for leanprover/lean4#6826 * chore: bump to nightly-2025-01-29 * . * merge lean-pr-testing-6812 * . * lake update * lake update * fixes and deprecations * name clash * fix * fix * update * lint * shake --------- Co-authored-by: leanprover-community-mathlib4-bot <[email protected]> Co-authored-by: Johan Commelin <[email protected]> Co-authored-by: Parth Shastri <[email protected]> Co-authored-by: Joachim Breitner <[email protected]> Co-authored-by: Yakov Pechersky <[email protected]> Co-authored-by: Ruben Van de Velde <[email protected]>
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 2, 2025
* fixes * fixes * chore: bump to nightly-2025-01-15 * fix * empty commit to bump CI * Update lean-toolchain for testing leanprover/lean4#6660 * fixes for leanprover/lean4#6660 * chore: bump to nightly-2025-01-16 * . * fix * chore: bump to nightly-2025-01-17 * deprecation * chore: bump to nightly-2025-01-18 * Merge master into nightly-testing * chore: bump to nightly-2025-01-19 * fix * chore: bump to nightly-2025-01-20 * fix and bump * bump ProofWidgets * chore: bump to nightly-2025-01-21 * bump * Adaptations * fixes * fix * fix * chore: bump to nightly-2025-01-22 * chore: adaptations for nightly-2025-01-22 * remove deprecation for List.indexOf_lt_length * chore: bump to nightly-2025-01-23 * chore: bump to nightly-2025-01-24 * Adjust expected output in MathlibTest.CountHeartbeats * chore: adaptations for nightly-2025-01-24 * chore: bump to nightly-2025-01-25 * chore: bump to nightly-2025-01-26 * chore: bump to nightly-2025-01-27 * Merge master into nightly-testing * Adaption for leanprover/lean4#6755 * Update lean-toolchain for testing leanprover/lean4#6800 * lake update for leanprover/lean4#6800 * Trigger CI for leanprover/lean4#6800 * fixes for leanprover/lean4#6800 * Trigger CI for leanprover/lean4#6800 * fix * Update lean-toolchain for testing leanprover/lean4#6812 * chore: bump to nightly-2025-01-28 * lake update for leanprover/lean4#6812 * TrivSqZeroExt.snd_list_prod fix * Update lean-toolchain for testing leanprover/lean4#6826 * Adaption * fix * fix * remove deprecation/alias * touch for CI for leanprover/lean4#6812 * fix for leanprover/lean4#6812 * Trigger CI for leanprover/lean4#6826 * chore: bump to nightly-2025-01-29 * . * merge lean-pr-testing-6812 * . * lake update * lake update * fixes and deprecations * name clash * fix * fix * update * lint * shake * fix(#count_heartbeats): add `approximately` flag to stabilise tests * chore: bump to nightly-2025-01-30 * add option also to the linter * use sleep_heartbeats in test * update * deprecation * don't count heartbeats * Update lean-toolchain for testing leanprover/lean4#6863 * use 'x * y' as match pattern * Trigger CI for leanprover/lean4#6863 * Trigger CI for leanprover/lean4#6863 * Trigger CI for leanprover/lean4#6863 * wip * Trigger Build * chore: bump to nightly-2025-01-31 * update * fix * chore: bump to nightly-2025-02-01 * chore: bump to nightly-2025-02-02 --------- Co-authored-by: leanprover-community-mathlib4-bot <[email protected]> Co-authored-by: Johan Commelin <[email protected]> Co-authored-by: Joachim Breitner <[email protected]> Co-authored-by: Yakov Pechersky <[email protected]> Co-authored-by: Ruben Van de Velde <[email protected]> Co-authored-by: adomani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
zetaUnusedsimp and reduction option (added in #6754).True by default, and implied by
zeta, this can be turned off to make simp even more careful about preserving the expression structure, including unused let and have expressions.Breaking change: The
splittactic no longer removes unused let and have expressions as a side-effect, in rare cases this may break proofs.dsimp onlycan be used to remove unused have and let expressions.