Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lake: set MACOSX_DEPLOYMENT_TARGET for shared libs #6631

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Jan 13, 2025

This PR sets MACOSX_DEPLOYMENT_TARGET for shared libraries (it was previously only set for executables).

@tydeu tydeu force-pushed the lake/macosx-shared-lib branch from c2d5fc8 to 5c680d9 Compare January 13, 2025 18:53
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 13, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 13, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 13, 2025
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jan 13, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@tydeu tydeu marked this pull request as ready for review January 13, 2025 20:12
@tydeu tydeu added this pull request to the merge queue Jan 13, 2025
Merged via the queue into leanprover:master with commit 749a82a Jan 13, 2025
19 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
This PR sets `MACOSX_DEPLOYMENT_TARGET` for shared libraries (it was
previously only set for executables).

(cherry picked from commit 749a82a)
@tydeu tydeu deleted the lake/macosx-shared-lib branch January 13, 2025 21:58
tydeu added a commit that referenced this pull request Jan 13, 2025
This PR sets `MACOSX_DEPLOYMENT_TARGET` for shared libraries (it was
previously only set for executables).

(cherry picked from commit 749a82a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport releases/v4.16.0 builds-mathlib CI has verified that Mathlib builds against this PR changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants