Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avoid some redundant proof terms in grind #6615

Merged
merged 4 commits into from
Jan 12, 2025
Merged

feat: avoid some redundant proof terms in grind #6615

merged 4 commits into from
Jan 12, 2025

Conversation

leodemoura
Copy link
Member

This PR adds two auxiliary functions mkEqTrueCore and mkOfEqTrueCore that avoid redundant proof terms in proofs produced by grind.

@leodemoura
chore: cleanu and add mkOfEqTrueCore
f45ff7f
@leodemoura
chore: add mkEqTrueCore
d23403e
@leodemoura
feat: ues mkOfEqTrueCore and mkEqTrueCore in grind
e65cc1d
@leodemoura
chore: adjust tests
e9fa72f 
Discrepancy between the behavior of `cases <term>`. The result depends
on whether `<term>` is a free variable or not. `<term> : a ∧ b`.
@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Jan 12, 2025
@leodemoura leodemoura enabled auto-merge January 12, 2025 22:49
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 12, 2025 22:58 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jan 12, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 12, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase c7939cfb03c78820b069ba9c931900d44b11f58e --onto d2c4471cfa4611977bf4927b5cd849df1a4272b7. (2025-01-12 23:13:19)

Merged via the queue into master with commit af8f3d1 Jan 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-bot