-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix typo and incorrect name in doc #4404
Conversation
Mathlib CI status (docs):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the typo fix.
It would be helpful if we had Eq.rfl
, so that it follows the naming convention of all the other relations which have both Foo.refl
and Foo.rfl
, and where Foo.rfl
has the argument implicit. After all the message suggests to use the right one for your relation. Just writing rfl
is confusing here, also with the tactic of the same name. Maybe we should introduce Eq.rfl
. Until then maybe list two possible lemmas (there aren't many in core, unfortunately.)
WDYT?
I agree that writing Could you advise how to fix the CI issue? If I do the suggested rebase command then it doesn't allow me to push. |
Co-authored-by: Joachim Breitner <[email protected]>
I don't think there is any rebasing to do. Once the test suite works (maybe the expected output isn't quite right yet) we can merge this. |
Waiting test to be fixed. |
Fixes typo "reflexivitiy" to "reflexivity", and changes exact Eq.rfl to exact rfl, since Eq.rfl does not exist.
(I got something confused wrt the bot message on #4367 and accidentally closed that one, so making this one instead, which I think satisfies the requirements it wanted.)