Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo and incorrect name in doc #4404

Merged
merged 5 commits into from
Jun 23, 2024
Merged

Conversation

b-mehta
Copy link
Contributor

@b-mehta b-mehta commented Jun 8, 2024

Fixes typo "reflexivitiy" to "reflexivity", and changes exact Eq.rfl to exact rfl, since Eq.rfl does not exist.

(I got something confused wrt the bot message on #4367 and accidentally closed that one, so making this one instead, which I think satisfies the requirements it wanted.)

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 8, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jun 8, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 748eab95113febbf8fa062643d06af3db49e0a1f --onto 287d46e1f6a7a6136c7996367a9b203d93797d00. (2024-06-08 03:56:23)
  • ✅ Mathlib branch lean-pr-testing-4404 has successfully built against this PR. (2024-06-08 17:10:29) View Log
  • ✅ Mathlib branch lean-pr-testing-4404 has successfully built against this PR. (2024-06-08 20:38:14) View Log

Copy link
Collaborator

@nomeata nomeata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fix.

It would be helpful if we had Eq.rfl, so that it follows the naming convention of all the other relations which have both Foo.refl and Foo.rfl, and where Foo.rfl has the argument implicit. After all the message suggests to use the right one for your relation. Just writing rfl is confusing here, also with the tactic of the same name. Maybe we should introduce Eq.rfl. Until then maybe list two possible lemmas (there aren't many in core, unfortunately.)

WDYT?

src/Init/Tactics.lean Outdated Show resolved Hide resolved
tests/lean/run/wfirred.lean Outdated Show resolved Hide resolved
@b-mehta
Copy link
Contributor Author

b-mehta commented Jun 8, 2024

I agree that writing Eq.rfl would be better here, but since it doesn't exist, I guessed that it would be unreasonable to add a new theorem in such a low-level file as part of a typo-fix only PR. How about Eq.refl _ for now, with a follow-up adding Eq.rfl in a separate PR?

Could you advise how to fix the CI issue? If I do the suggested rebase command then it doesn't allow me to push.

Co-authored-by: Joachim Breitner <[email protected]>
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 8, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 8, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jun 8, 2024
@nomeata
Copy link
Collaborator

nomeata commented Jun 8, 2024

I don't think there is any rebasing to do. Once the test suite works (maybe the expected output isn't quite right yet) we can merge this.

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 8, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 8, 2024
@leodemoura leodemoura added the awaiting-author Waiting for PR author to address issues label Jun 18, 2024
@leodemoura
Copy link
Member

Waiting test to be fixed.

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 23, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 23, 2024
@nomeata nomeata added this pull request to the merge queue Jun 23, 2024
@nomeata nomeata removed the awaiting-author Waiting for PR author to address issues label Jun 23, 2024
Merged via the queue into leanprover:master with commit 43a9c73 Jun 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants