Skip to content

Commit

Permalink
fix: lake: v4.16.0-rc1 trace issues (#6627)
Browse files Browse the repository at this point in the history
This PR aims to fix the trace issues reported by Mathlib that are
breaking `lake exe cache` in downstream projects.
tydeu authored Jan 13, 2025
1 parent 8483ac7 commit a6eea4b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/lake/Lake/Build/Job.lean
Original file line number Diff line number Diff line change
@@ -265,7 +265,7 @@ results of `a` and `b`. The job `c` errors if either `a` or `b` error.
/-- Merges this job with another, discarding its output and trace. -/
def add (self : Job α) (other : Job β) : Job α :=
self.zipResultWith (other := other) fun
| .ok a sa, .ok _ sb => .ok a (sa.merge sb)
| .ok a sa, .ok _ sb => .ok a {sa.merge sb with trace := sa.trace}
| ra, rb => .error 0 {ra.state.merge rb.state with trace := ra.state.trace}

/-- Merges this job with another, discarding both outputs. -/

0 comments on commit a6eea4b

Please sign in to comment.