Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the program type in ArmState to Map #27

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Conversation

shigoel
Copy link
Collaborator

@shigoel shigoel commented Mar 25, 2024

Description:

Change the program type to Map (courtesy @aqjune-aws).

Before this change, the program field in ArmState had the following type:
Store (BitVec 64) (Option (BitVec 32))
Now its type is:
Map (BitVec 64) (BitVec 32)

An immediate fallout is that the precondition for symbolic simulation/code reasoning will now become:
s0.program = <program_map>
instead of
s0.program = <program_map>.find?

Testing:

make all succeeded.

License:

By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

@shigoel shigoel requested a review from aqjune-aws March 25, 2024 18:54
@shigoel shigoel changed the title Wip Change the program type in ArmState to Map Mar 25, 2024
Copy link
Collaborator

@aqjune-aws aqjune-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@shigoel shigoel merged commit b148912 into leanprover:main Mar 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants