refactor: change memory-effects theorem to a quantifier-free statement #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeizer
force-pushed
the
extract-memory-effects
branch
from
077b5da to
6295e15
Compare
alexkeizer
force-pushed
the
memory-effects-proof-as-mem-equals
branch
from
072cea4 to
355d210
Compare
We now only have two, much simpler, sorries left in Memory.read_write_bytes_different
alexkeizer
force-pushed
the
memory-effects-proof-as-mem-equals
branch
from
f428b84 to
a221670
Compare
alexkeizer
changed the title
|
@bollu I touched some memory lemmas here, care to review? |
|
All errors introduced by the merge of main should now be fixed |
bollu
reviewed
Oct 15, 2024
bollu
reviewed
Oct 15, 2024
bollu
reviewed
Oct 15, 2024
alexkeizer
commented
Oct 15, 2024
Co-authored-by: Siddharth <[email protected]>
shigoel
reviewed
Oct 15, 2024
shigoel
reviewed
Oct 15, 2024
|
@alexkeizer LGTM, modulo one comment above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes the memory effect proof to be of type
<currentState>.mem = <trace of memory writes>.mem, instead of the quantified statement that the result of reading from memory at any bytes and any address of either state agrees.memory_rulesto the simpsets that are used by sym_n.memory_rulesto do, e.g., read-over-write reasoning, ands[base, n]notation to desugar intos.mem.read_bytes ..Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine?
Yes
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.