[Merged by Bors] - chore(Tactic/Linter): do not import TextBased linter
#17187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneugster
added
the
easy
PR summary 2daeefc6b4
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Tactic.Linter | 24 | 20 | -4 (-16.67%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 4228 files with changed transitive imports taking up over 178798 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
|
Thanks! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by adomani. |
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
TextBased linterTextBased linter
chrisflav
pushed a commit
that referenced
this pull request
Oct 1, 2024
fbarroero
pushed a commit
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mathlib.Tactic.Linter.TextBasedis only used by the scriptlake exe lint-styleand therefore does not to be imported by Mathlib.A future PR might factor this out to live completely outside
Mathlib/, but I don't want to do that until the text-based unicode linter PRs (starting with #17129) are approved.