Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: removes non-breaking spaces (U+00a0) #16257

Closed
wants to merge 5 commits into from

Conversation

adomasbaliuka
Copy link
Collaborator

Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).


Relevant discussions:

Open in Gitpod

@adomasbaliuka adomasbaliuka changed the title Removes all non-breaking spaces (U+00a0) from Mathlib chore: Removes all non-breaking spaces (U+00a0) from Mathlib Aug 29, 2024
Copy link

github-actions bot commented Aug 29, 2024

PR summary 029839cae9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@adomasbaliuka adomasbaliuka requested a review from grunweg August 29, 2024 14:07
@grunweg grunweg changed the title chore: Removes all non-breaking spaces (U+00a0) from Mathlib chore: removes non-breaking spaces (U+00a0) Aug 29, 2024
@grunweg
Copy link
Collaborator

grunweg commented Aug 29, 2024

Are there any such spaces in the archive, tests or counterexamples?
(This need not block this PR; I think these changes are useful in any case.)

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

Mathlib/Condensed/Light/TopCatAdjunction.lean Outdated Show resolved Hide resolved
Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@adomasbaliuka
Copy link
Collaborator Author

Are there any such spaces in the archive, tests or counterexamples? (This need not block this PR; I think these changes are useful in any case.)

As far as I can see, there are no more in the entire repository.

@sgouezel
Copy link
Contributor

bors r+
Thanks!

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 29, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 29, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 29, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Aug 29, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 29, 2024

Build failed (retrying...):

@adomasbaliuka
Copy link
Collaborator Author

adomasbaliuka commented Aug 29, 2024

@sgouezel it seems that a linter complains about a too long line in a file this PR didn't change? How can that happen? Probably has something to do with the fact that the line-length linter was changed earlier today?

mathlib-bors bot pushed a commit that referenced this pull request Aug 29, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 29, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Aug 29, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 29, 2024

Build failed:

@sgouezel
Copy link
Contributor

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

Build failed (retrying...):

@adomasbaliuka
Copy link
Collaborator Author

@grunweg @sgouezel the "overlong" line that the bors build complains about isn't actually overlong. So I have no idea what's happening here...

@bryangingechen
Copy link
Contributor

The lint failure might be from another PR currently being merged or from a commit in master which isn't in this branch yet. In any case this PR now has a merge conflict with master as well, so I'm taking it off the queue:
bors r-

After merging master and fixing any errors, feel free to put this back on the queue:
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

✌️ adomasbaliuka can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

Canceled.

@bryangingechen bryangingechen removed the ready-to-merge This PR has been sent to bors. label Aug 30, 2024
@adomasbaliuka
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Aug 30, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: removes non-breaking spaces (U+00a0) [Merged by Bors] - chore: removes non-breaking spaces (U+00a0) Aug 30, 2024
@mathlib-bors mathlib-bors bot closed this Aug 30, 2024
@mathlib-bors mathlib-bors bot deleted the adomas_removeNonbreakingSpaces branch August 30, 2024 16:12
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
Removes all non-breaking spaces (U+00a0) from Mathlib.

This is in preparation for using the "unicode linter" (#16215), which would (as of now) disallow non-printing characters except for space (U+0020) and linefeed (U+000A).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants