Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercises for Ch.Syntax & Ch.Elaboration #87

Merged

Conversation

lakesare
Copy link
Contributor

@lakesare lakesare commented Feb 24, 2023

[Based on #84]

In this PR

  • Created exercises & solutions for Ch.Syntax
  • Created exercises & solutions for Ch.Elaboration
  • Fixed missing code blocks in Ch.MetaM exercises
  • in /solutions we used to have abridged descriptions of the exercise text - removed that, let's just have the exercise number

Links to the latest versions of updated files

@lakesare lakesare marked this pull request as draft February 24, 2023 08:43
@lakesare lakesare force-pushed the lakesare_exercises_2 branch 3 times, most recently from e9aaf79 to 6292abf Compare February 24, 2023 09:29
@lakesare lakesare force-pushed the lakesare_exercises_2 branch from 6292abf to 91bcf2a Compare February 24, 2023 09:31
@lakesare lakesare marked this pull request as ready for review February 24, 2023 09:54
Copy link
Collaborator

@hargoniX hargoniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my remarks on the syntax chapter since that's the one I am most familiar with.

Its mostly just didactic nit picks, I think the approach is quite good in general 👍

lean/main/syntax.lean Show resolved Hide resolved
lean/main/syntax.lean Show resolved Hide resolved
lean/solutions/syntax.lean Show resolved Hide resolved
lean/solutions/syntax.lean Show resolved Hide resolved
lean/solutions/syntax.lean Show resolved Hide resolved
lean/main/syntax.lean Show resolved Hide resolved
lean/main/syntax.lean Show resolved Hide resolved
@lakesare
Copy link
Contributor Author

@arthurpaulino, I think it's good to merge.

@arthurpaulino
Copy link
Collaborator

Amazing, thank you!

@arthurpaulino arthurpaulino merged commit 7fbf966 into leanprover-community:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants