-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding exercises #85
Adding exercises #85
Conversation
@arthurpaulino, what's a good strategy for checking out the pdf outputs, do you do it locally/just push to master and hope for the best? |
Sure, feel free to do it. But I was not the one who wrote it. If you need help, please ping Julian Berman on Zulip |
But what strategy do you use yourself though? |
I do as you said: I hope it will work. When we started this book, there was no pdf. We just cared mostly about the resulting markdown files. The pdf came after. |
2d0edc0
to
66c48a5
Compare
Aha, then I'll just rely on Should we review/merge now, with exercises for 1 chapter and 1 subchapter, or would it be better to add some more chapters before merging? |
Fix spacing Ch.Expressions - improve exercise formatting
66c48a5
to
1fc410c
Compare
I believe it's a good time to ask for review from people who are up to date with Lean 4 metaprogramming API. I will review, but it's also good to ask the community to do it |
@lakesare How do you think the solutions should be accessible via the repo's README? |
@arthurpaulino, I thought about it, I think the following should be good for now:
|
Sounds good. Would be nice to have some preliminary comments from you, and then I'll commit another subchapter tomorrow & call someone to review it. Update:: decided to finish up the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great work!
Co-authored-by: Arthur Paulino <[email protected]>
Co-authored-by: Arthur Paulino <[email protected]>
[Based on #84]
This PR adds exercises to the Expressions and MetaM chapters.
TODOs
Readme.md
sourceOfTruth
folder that will contain all exercises and solutions. Later, we might want to make "this goes to the end of the chapter", "this goes to the end of the book in the solutions section" thing automatic..md
s [in this PR description] for comfortable reviewingNotes
I added the "source of truth" folderlean/exercises
with both exercises and solutions. While you're developing the exercises it's best to have both the text of the exercise and the solution in front of you. After that, you copypaste exercises into the end of the chapter; and abridged exercises + solution into the end of the book (manually!).Probably possible (and would be nice!) to automate.
If we automate this, we still need a source of truth.
If we don't automate this, this still seems to be the best workflow (change source of truth as you like; see the changes in git; adjust exercises and solutions).
We decided to remove the source of truth files, these can remain on the developer's machine.