Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use Option.get instead of Options.get #154

Merged
merged 1 commit into from
Jan 14, 2025
Merged

chore: Use Option.get instead of Options.get #154

merged 1 commit into from
Jan 14, 2025

Conversation

eric-wieser
Copy link
Member

The implemention of Option.get is exactly what was written here.

The implemention of `Option.get` is exactly what was written here.
@eric-wieser eric-wieser requested a review from adomani January 13, 2025 16:51
@adomani
Copy link
Collaborator

adomani commented Jan 14, 2025

Thanks!

There is no CI for this repository: should I simply push the big green button that I learned to fear so much?

@eric-wieser
Copy link
Member Author

There is CI; check out the green check next to my commit!

@Julian
Copy link
Collaborator

Julian commented Jan 14, 2025

We don't check anything other than "does the PDF build" at the minute in CI, none of the Lean code actually gets executed (nor does any inline output get checked).

All that being said as someone who's merged a bunch of PRs in the repo yes I think be bold and hit the button when comfortable, as otherwise things stagnate.

@adomani adomani merged commit 7d9e59f into master Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants