Fix: off-by-one random generation erro in hex_octet #109 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original hex_octet has probability 6% of generating octet less-than-4 characters, which is not well-formed to use in file key. @see comments on leancloud#109.
| @@ -133,7 +133,7 @@ def save(self): | |||
| base64.encode(self._source, output) | |||
| self._source.seek(0) | |||
| output.seek(0) | |||
| hex_octet = lambda: hex(int(1 + random.random() * 0x10000))[2:] | |||
| hex_octet = lambda: hex(int(0x10000 * (1 + random.random())))[2:] | |||
There was a problem hiding this comment.
请大家帮忙仔细审阅，上面的算法需要与下面一致：
g = (1 + random.random()) * 0x10000
h = hex(int(g))[2:]我之前的PR #109 在这里犯了严重的错误。:(
|
好像还是有些问题，新的算法生成出来的都是五位字符，并且第一位总是为 |
|
hoo... 抱歉，确实有问题。 新的问题在于 python 中 hex 生成的 string 包括了 hex(int(0x10000 * (1 + random.random())))[-4:]我再 push 一个 commit 上来。 |
|
我觉得应该没有问题了 👍 |
|
谢谢！ |
aisk
added a commit
that referenced
this pull request
Oct 27, 2015
Fix: off-by-one random generation erro in hex_octet #109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original hex_octet has probability 6% of generating
octet less-than-4 characters, which is not well-formed
to use in file key.
@see comments on #109.