Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc when release #172

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Update doc when release #172

merged 3 commits into from
Apr 10, 2020

Conversation

juvenn
Copy link
Member

@juvenn juvenn commented Apr 13, 2018

No description provided.

@weakish
Copy link
Contributor

weakish commented Apr 9, 2020

现在直接 make doc 会报错 Fatal error: Cannot use 'Object' as class name as it is reserved,还需要切换到 php 5 再跑。

或者干脆去掉 PHP 5 的支持(官方是 2018 年底就 EOL 了)?

@juvenn
Copy link
Member Author

juvenn commented Apr 9, 2020

php 的用户往往升级慢,我还是想保留一下 5.5 支持。

make doc 报错,有没有变通的办法可以解决呢?如果实在不行的话,那就抛弃 5.5 吧。

@weakish
Copy link
Contributor

weakish commented Apr 10, 2020

有没有变通的办法可以解决呢

@juvenn 就切到 php5 就行。我提了 suggestion(顺便在跑 make doc 前把 docs 目录删一下,否则 apigen 检测到目录已存在,会提示是否覆盖,还要按一下 enter 确认)

@weakish weakish mentioned this pull request Apr 10, 2020
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #172 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #172   +/-   ##
=========================================
  Coverage     66.89%   66.89%           
  Complexity      802      802           
=========================================
  Files            36       36           
  Lines          2287     2287           
=========================================
  Hits           1530     1530           
  Misses          757      757           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6af96...9da6de9. Read the comment docs.

@juvenn
Copy link
Member Author

juvenn commented Apr 10, 2020

我提了 suggestion

好高级,我 apply suggestion 了。

@juvenn
Copy link
Member Author

juvenn commented Apr 10, 2020

但是,我好像不能 approve ,因为是我提的 pr 。你直接 approve merge 吧。

@weakish weakish merged commit 4b3a050 into leancloud:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants