Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix utility predicates not being instantiated on start #10593

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix utility predicates not being instantiated on start #10593

merged 1 commit into from
Jan 13, 2025

Conversation

Thodor12
Copy link
Contributor

Closes #10592

Changes proposed in this pull request

  • Instantiate the predicates directly, not requiring a separate method to call.

This works safely, even on a dedicated server. The recipes get populated before NBT load is invoked, so the menu doesn't get wiped either.

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@someaddons someaddons merged commit 6758621 into version/main Jan 13, 2025
5 checks passed
@someaddons someaddons deleted the fix/utility_predicates branch January 13, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minecolonies:cook has thrown an exception
2 participants
@Thodor12 @someaddons