Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stuckhandler rework #10588

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Stuckhandler rework #10588

merged 1 commit into from
Jan 12, 2025

Conversation

someaddons
Copy link
Contributor

Closes #
Closes #

Changes proposed in this pull request

  • Reworked stuck handling, nonsafe destinations are now eligible for partial stuck handling.
  • Calling .stop on the navigator signals no further entity movement is desired, also reset stuck handling.
  • Fixed a bug causing the stuck handler to not progress further than random moving(outside of global timeout tp)
  • Fixed a bug where citizens started from a wrong position, when they were standing on the edge of a block
  • Citizen info command no longer prints duplicate information, nor sends it to all OP. Now also displays stuck level.
  • Citizen info command now allows teleporting to the displayed coordinates on click

Testing

  • [x ] Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@someaddons
Reworked stuck handling, nonsafe destinations are now eligible for pa…
3eedff8 
…rtials stuck handling.

Fixed a bug causing the stuck handler to not progress further than random moving(outside of global timeout tp)
Fixed a bug where citizens started from a wrong position, when they were standing on the edge of a block
Calling .stop on the navigator signals no further entity movement is desired, also reset stuck handling.
Citizen info command no longer prints duplicate information, nor sends it to all OP. Now also displays stuck level.
@Raycoms Raycoms merged commit abbb0d9 into version/main Jan 12, 2025
5 checks passed
@Raycoms Raycoms deleted the stuckhandler branch January 12, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raycoms Raycoms Raycoms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@someaddons @Raycoms