forked from daphne-eu/daphne
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Several build targets depend on the existence of a number of .inc files which are TableGen'erated from the DaphneIR sources. - For some of those targets, these dependencies were not explicitly specified. - Affected targets: DaphneCatalogParser, DaphneDSLParser, SQLParser, CompilerUtils, Util. - These targets could not be built in isolatation so far (e.g., `./build.sh --target DaphneCatalogParser` failed due to some missing .inc files). - This may not seem like a significant problem, since these targets are anyway not intended to be used without the rest of the system. - However, it seems like the insufficient dependency information could lead to problematic orderings of the individual targets during a full build by cmake/ninja, where the build of a target requiring the .inc files was started before the targets generating the .inc files were started/done. - Most likely, this is the reason why the GitHub action (CI) of building DAPHNE failed in commit 2b4f086. - The problem may also be related to non-determinism caused by a multi-threaded built, as building DAPHNE at that commit worked well on my machine (same for the GitHub action executed locally). - This commit makes the dependencies on the .inc files explicit for the targets mentioned above.
- Loading branch information
Showing
5 changed files
with
65 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters