Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #101

Merged
merged 25 commits into from
May 9, 2024
Merged

Test #101

merged 25 commits into from
May 9, 2024

Conversation

scossu
Copy link
Collaborator

@scossu scossu commented May 7, 2024

@thisismattmiller This PR will merge several major improvements and at least one breaking change, which is that the /trans and /feedback endpoints will accept a JSON payload. This needs to be reflected by all clients currently using those endpoints.

Let me know if we need some special arrangements to deploy this. I am still working on some details and documentation, so I'm not ready for a review yet.

I'm planning to tag this as 1.0.0 because of the breaking API change.

scossu and others added 22 commits February 28, 2024 08:38
* WIP Parse Chinese numerals.

* WIP complete number parsing.

* Complete Chinese numerals:

* Use standard table override instead of pre-config hooks.
* Add few test strings.

* Complete numerals:

* Transliterate all numeric examples correctly
* Modify hook return logic for consistency
* WIP partial spacing fix.

* Some cleanup; upgrade docker OS.

* Add dependency for uwsgi.
commit 30859a5
Author: scossu <[email protected]>
Date:   Wed Feb 28 22:17:36 2024 -0500

    Move ext checkout to github actions.

commit 6d8da6d
Author: scossu <[email protected]>
Date:   Wed Feb 28 21:45:01 2024 -0500

    Use git clone instead of submodule.

commit ade9da5
Author: scossu <[email protected]>
Date:   Wed Feb 28 21:42:45 2024 -0500

    Manually add yiddish submodules.

commit 77cb9ef
Author: scossu <[email protected]>
Date:   Wed Feb 28 21:23:37 2024 -0500

    Do not remove yiddish module.

commit e405b36
Author: scossu <[email protected]>
Date:   Wed Feb 28 09:11:41 2024 -0500

    Fix WORKDIR in Dockerfile

commit 95445ba
Author: scossu <[email protected]>
Date:   Wed Feb 28 09:07:50 2024 -0500

    Change refs for Yiddish submodules.

commit 208ea09
Author: scossu <[email protected]>
Date:   Wed Feb 28 08:45:58 2024 -0500

    Update checkout workflow.
@scossu
Copy link
Collaborator Author

scossu commented May 7, 2024

NB This PR also introduces the splitting of Docker image into a scriptshifter-base and scriptshifter to alleviate the very long build times that installing ML tools requires. the base image installs all the major dependencies, while the ap image only copies the scriptshifter code and runs the entrypoint script.

@scossu scossu requested a review from thisismattmiller May 8, 2024 11:53
@scossu scossu marked this pull request as ready for review May 8, 2024 11:55
Copy link
Member

@thisismattmiller thisismattmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No special arrangements need for the breaking changes to deploy on our side thanks.

@scossu scossu merged commit fa5b48d into main May 9, 2024
1 check passed
@scossu scossu mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants